1462299 - input[date] unusable on Android 4.x

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jesse Jaara]

Attachment: Firefox-datepicker.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Steps to reproduce:

Click on empty date[input] widget.


Actual results:

Firefox presents user with a date input dialog that has no selector input for year or month. Only way to enter date, say 10 years in past, is to scroll trough 120 months of date screens.

See attachment: Firefox-datepicker.png


Expected results:

Get a date input dialog that allows one to change the year in a sensible manner. Android 4.4 dies provide such UI widget, but Firefox does not simply use it. This can be sen for example in the Android emulator Api Demos app (Views/Date Widgets/1. Dialog).

See attachment: api-demo-datepicker.png

Comment 1

[Jesse Jaara]

Attachment: api-demo-datepicker.png

Comment 2

[Jesse Jaara]

This problem is also present already on Android 4.2. Have not tested 4.1, but probably is also present there.

Comment 3

[Jan Henning [:JanH]]

We've just switched to using the system DatePicker control in bug 1318046, but the way we're using it on Android 4.x we still don't actually allow easily changing the year and actually made the layout worse (bug 1460585).

So yes, this needs some more work to properly function.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1462299 - input[date] unusable on Android 4.x;

The issue stemmed from platform's DatePicker.
To make amends and fix both this bug and Bug 1460585 I went with
hiding the calendar and showing only the spinners for Api <21.

Review commit: https://reviewboard.mozilla.org/r/255928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255928/

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8990929 [details]
Bug 1462299 - input[date] unusable on Android 4.x;

https://reviewboard.mozilla.org/r/255928/#review262948

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: DatePickerApi19.png

This is how the DatePicker will look like on API <21 using only spinners.
This change means the DatePicker will also be more in line with how the other Date/Time pickers look like on API <21, all of them using just spinners now.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef400c4f3907
input[date] unusable on Android 4.x; r=jchen

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ef400c4f3907

Comment 9

[Stefan Deiac]

Verified as fixed on devices: Lenovo A536 (4.4.2) and Prestigio Grace X5 (4.4.2). 
Build: Nightly 63.0a1 (2018-07-16).

Comment 10

[Julien Cristau [:jcristau]]

Should this be uplifted to beta?

Comment 11

[Petru-Mugurel Lingurar [:petru]]

(In reply to Julien Cristau [:jcristau] from comment #10)
> Should this be uplifted to beta?

I was planning to finish all tickets from Bug 1464997 and then ask uplift for all of them. Should be this week.

Comment 12

[Bogdan Surd, QA [:bsurd, NI]]

As per Comment 9 marking as verified.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta backport?

Comment 14

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8990929 [details]
Bug 1462299 - input[date] unusable on Android 4.x;

Approval Request Comment
[Feature/Bug causing the regression]: DatePicker on API <21
[User impact if declined]: Can only select a certain month/year by scrolling through the months.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]: --
[Is the change risky?]: No
[Why is the change risky/not risky?]: Has been QE verified and in the time being in Nightly no issues have been reported.
[String changes made/needed]: --

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8990929 [details]
Bug 1462299 - input[date] unusable on Android 4.x;

One of several small fixes for the date picker related to the switch in 62 to using the platform library. Verified in nightly. 
Let's uplift for next Monday's beta 17 build.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7480f990a104

Comment 17

[Ioana Chiorean]

Can you please check this, Igor?

Comment 18

[Bogdan Surd, QA [:bsurd, NI]]

Devices:
 - Lenovo A536 (4.4.2);
 - Prestigio Grace X5 (4.4.2). 

Verified as fixed in 62.0b17, all of the date/date-time pickers work as expected.