Closed Bug 1462675 Opened Last year Closed Last year
The "Edit Pop-up Blocker Options/Preferences" command is broken
59 bytes, text/x-review-board-request
The "Edit Pop-up Blocker Preferences" command in the notification bar shown when a popup is blocked is the last user of "permissions.xul" in a separate window that remains in non-test code. This feature is currently broken because of a reference to a missing string, but the correct fix is actually to open the dialog in-content instead.
The feature works on Release, I haven't tested Beta but if it's broken there and we can reuse a different string, we may just want to fix the reference there.
Hey Johann, how important is this?
Works fine in Beta, regressor is probably bug 1457948 (removed a string that was still used here: https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/browser/base/content/browser.js#804) Pretty sad that we don't have tests for this. In any case we should really fix this before it goes into Beta/Release. I agree that we could just consider linking to about:preferences -> permissions on that button instead... Gandalf, would you be interested in fixing opening this dialog or making this button open the popup preferences? I'd be okay with either.
Giving this bug a poke - I will email :gandalf.
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Ugh, apologies for the regression. I usually go through searchfox for all strings I'm migrating but I must have skip it somehow. Fortunately the fix is trivial.
Summary: The "Edit Pop-up Blocker Options/Preferences" command should open the permissions dialog in-content → The "Edit Pop-up Blocker Options/Preferences" command is broken
Comment on attachment 8983259 [details] Bug 1462675 - Fix permissions popup dialog opened from browser.js. https://reviewboard.mozilla.org/r/249150/#review255378 Thanks for the fix! It might still be worth keeping track of the original bug intent ("The "Edit Pop-up Blocker Options/Preferences" command should open the permissions dialog in-content") in a separate P3 bug.
Attachment #8983259 - Flags: review?(jhofmann) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/50305cce4a82 Fix permissions popup dialog opened from browser.js. r=johannh
Backed out 1 changesets (bug 1462675) for ESlint failures a=backout on a CLOSED TREE push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=50305cce4a821a2ee6101951900c83fa474cea15&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=1c7d89955364c87b891157ffdde74be8c3ea74cc&selectedJob=181881259&filter-searchStr=Linting+opt+source-test-mozlint-eslint+%28ES%29 log: https://treeherder.mozilla.org/logviewer.html#?job_id=181881259&repo=autoland https://hg.mozilla.org/integration/autoland/rev/209db28837273b37b65ab97c7c8c6e0892c285a8
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/e5c62d5cd62d Fix permissions popup dialog opened from browser.js. r=johannh
Reproduced the issue on a nightly build from 2018-05-18. Verified as fixed in Nighlty 63.0a1(2018-07-11) and 62.0b7 with Windows 10x64, Ubuntul 14.04 and MacOS 10.13.
You need to log in before you can comment on or make changes to this bug.