Closed Bug 1462675 Opened Last year Closed Last year

The "Edit Pop-up Blocker Options/Preferences" command is broken

Categories

(Firefox :: Site Identity and Permission Panels, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 62
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 + verified
firefox63 --- verified

People

(Reporter: Paolo, Assigned: zbraniecki)

References

Details

(Keywords: regression)

Attachments

(1 file)

The "Edit Pop-up Blocker Preferences" command in the notification bar shown when a popup is blocked is the last user of "permissions.xul" in a separate window that remains in non-test code.

This feature is currently broken because of a reference to a missing string, but the correct fix is actually to open the dialog in-content instead.
The feature works on Release, I haven't tested Beta but if it's broken there and we can reuse a different string, we may just want to fix the reference there.
Hey Johann, how important is this?
Flags: needinfo?(jhofmann)
Works fine in Beta, regressor is probably bug 1457948 (removed a string that was still used here: https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/browser/base/content/browser.js#804)

Pretty sad that we don't have tests for this. In any case we should really fix this before it goes into Beta/Release.

I agree that we could just consider linking to about:preferences -> permissions on that button instead...

Gandalf, would you be interested in fixing opening this dialog or making this button open the popup preferences? I'd be okay with either.
Blocks: 1457948
Flags: needinfo?(jhofmann) → needinfo?(gandalf)
Priority: -- → P1
Giving this bug a poke - I will email :gandalf.
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Flags: needinfo?(gandalf)
Ugh, apologies for the regression. I usually go through searchfox for all strings I'm migrating but I must have skip it somehow. Fortunately the fix is trivial.
Summary: The "Edit Pop-up Blocker Options/Preferences" command should open the permissions dialog in-content → The "Edit Pop-up Blocker Options/Preferences" command is broken
Comment on attachment 8983259 [details]
Bug 1462675 - Fix permissions popup dialog opened from browser.js.

https://reviewboard.mozilla.org/r/249150/#review255378

Thanks for the fix!

It might still be worth keeping track of the original bug intent ("The "Edit Pop-up Blocker Options/Preferences" command should open the permissions dialog in-content") in a separate P3 bug.
Attachment #8983259 - Flags: review?(jhofmann) → review+
Blocks: 1466817
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50305cce4a82
Fix permissions popup dialog opened from browser.js. r=johannh
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5c62d5cd62d
Fix permissions popup dialog opened from browser.js. r=johannh
https://hg.mozilla.org/mozilla-central/rev/e5c62d5cd62d
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Reproduced the issue on a nightly build from 2018-05-18.
Verified as fixed in Nighlty 63.0a1(2018-07-11) and 62.0b7 with Windows 10x64, Ubuntul 14.04 and MacOS 10.13.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.