1466817 - The "Edit Pop-up Blocker Options/Preferences" command should open the in-content preferences

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[:Paolo Amadini]

The "Edit Pop-up Blocker Preferences" command in the notification bar shown when a popup is blocked is the last user of "permissions.xul" in a separate window that remains in non-test code.

Changing this to open the preferences in-content will allow us to remove support for opening the dialog in a separate window.

While the "Edit Pop-up Blocker Preferences" is not covered by regression tests, some other tests may currently open the dialog in a separate window, and they may have to be adjusted.

Comment 1

[:Paolo Amadini]

Attachment: Bug 1466817 - The "Edit Pop-up Blocker Options/Preferences" command should open the in-content preferences. r=jaws

Instead of opening the pop-up permissions dialog with the origin already populated, this command now highlights the pop-up permission row in the preferences. This doesn't remove any functionality because the only action that would be available for the origin in the permissions dialog is "Allow", which is equivalent to the "Allow pop-ups for" command in the notification bar menu.

Comment 2

[:Paolo Amadini]

I'd like to uplift this to Beta to fix bug 1514223. This also removes the last use of the permissions dialog outside of the in-content preferences.

Comment 3

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2f2032593ee660781bc0cdb09141275c6f84f10

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6960ca4db506
The "Edit Pop-up Blocker Options/Preferences" command should open the in-content preferences. r=jaws

Comment 6

[:Paolo Amadini]

[Tracking Requested - why for this release]:
Tracking requested per bug 1514223.

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6960ca4db506

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 9

[Timea Cernea [:tbabos][inactive]]

Verified - Fixed on latest Nightly 66.0a1 (2018-12-28) on Windows 10, Mac OS 10.13 and Ubuntu 16.04
Clicking on Option -> Edit Pop-up Blocker options... will lead the user to the about:preferences#privacy page with the "Block pop-up windows" option highlighted.

Comment 10

[:Paolo Amadini]

Comment on attachment 9032629 [details]
Bug 1466817 - The "Edit Pop-up Blocker Options/Preferences" command should open the in-content preferences. r=jaws

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1493844

User impact if declined: Bug 1514223

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: See comment 9

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Risk is limited to the feature

String changes made/needed: None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9032629 [details]
Bug 1466817 - The "Edit Pop-up Blocker Options/Preferences" command should open the in-content preferences. r=jaws

[Triage Comment]
Fixes a styling issue and provides a more consistent preferences experience. Approved for 65.0b8.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d444faf56f5c

Comment 13

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on 65.0b8 20190103150357 on Winddows 10 x32 , Ubuntu 16.04 x64 and OSX 10.14.2.