1462790 - Update Save to Pocket icons to use outline icon treatment

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P3)

Description

[pcho]

Attachment: Pocket outline icons for Firefox

We'd like to use an outlined version of the Pocket icon in Firefox for UI where you can save a page to Pocket. The icon then changes to the filled red version after you click it.

This would affect the awesome bar and Page actions menu. These would use the 16px version. It also would appear in the Reader view, which would use the 20px version. In both cases the outline remains a 2px border.

The "View Pocket List" menu action would still be the filled version of the icon.

Comment 1

[pcho]

Attachment: These are SVG icons at 16px and 20px sizes with black, dark, and light color applied.

Comment 2

[pcho]

Comment on attachment 8977103 [details]
Pocket outline icons for Firefox

This is the older version

Comment 3

[pcho]

Attachment: Pocket outline icon for FF v2

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: pocket.svg

I ran Peter's SVGs through SVGO, added the License header, and added the context-fill and context-fill-opacity values. So they should be good to go.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: pocket-outline.svg

Comment 6

[Mike de Boer [:mikedeboer]]

Drew, do you have the cycles available to swap out the icons for the pocket page action?

Comment 7

[Drew Willcoxon :adw]

Sure.

Comment 8

[Drew Willcoxon :adw]

Attachment: Bug 1462790 - Update Save to Pocket icons to use outline icon treatment. r?jaws

Update the Save to Pocket svg icons in the urlbar, page action panel, and reader view. There's another Save to Pocket icon in activity stream that the bug doesn't mention but that should probably be updated too. I'll make a different revision for it.

Comment 9

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e067e5aad358cd0bf6038c9fc890b6d802d44bf

Comment 10

[Phabricator Automation]

Comment on attachment 8997102 [details]
Bug 1462790 - Update Save to Pocket icons to use outline icon treatment. r?jaws

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

https://phabricator.services.mozilla.com/D2676

Comment 11

[Drew Willcoxon :adw]

Something happened to the last try push...

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7847f8ca5a8d3d12eef3a5b82101f4fbbebc2c18

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2dfd67e6fc8
Update Save to Pocket icons to use outline icon treatment. r=jaws

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d2dfd67e6fc8

Comment 14

[Scott [:thecount] Downe]

I filed this https://bugzilla.mozilla.org/show_bug.cgi?id=1481503 which is a small issue related to this patch. Dunno who else to cc on it though. :)

Comment 15

[Oana Botisan, Desktop QA]

I verified the fix using latest Nightly 64.0a1 and beta 63.0b11 on Windows 10 x64, macOS 10.13 and Ubuntu 16.04. The outlined version of the Pocket icon is displayed in awesome bar, Page actions menu and Reader View.