1481503 - Use pocket outline for save action and solid pocket for saved

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

Attachment: saved.png

Recently this landed https://bugzilla.mozilla.org/show_bug.cgi?id=1462790

However, it was noticed the patch also changed some icons on activity stream.

In the pr for awesome bar: https://github.com/xeonchen/gecko/commit/35f405d3b5c65e68ae4c45127b87a8981cb44e39

It updates two icons:
browser/components/newtab/data/content/assets/glyph-pocket-16.svg
browser/extensions/pocket/content/panels/img/pocket-outline.svg

However, by looking around, it looks like glyph-pocket-16.svg is only used in activity stream, and probably should just be reverted.

If I am correct, this should be an easy fix.

See attachment, that icon should be solid and not outlined.

Comment 1

[Ed Lee :Mardak]

Looks like the intent is to make the save action be the outline and after saved is solid? Activity stream was using the same icon for both the context menu and the saved card icon. So the fix is probably to have both icons then… ?

Comment 2

[Ed Lee :Mardak]

Attachment: before bug 1462790 (solid)

Comment 3

[Ed Lee :Mardak]

Attachment: after bug 1462790 (outline)

Comment 4

[Ed Lee :Mardak]

Attachment: fix v1 (outline save, solid saved)

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4291

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/65eacf8eef567356aef588c63c902dc50ccbd224
fix(icons): Allow two different pocket icons for different save vs saved contexts (#4291)

Fix Bug 1481503 - Use pocket outline for save action and solid pocket for saved

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/f99759ea7410

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of "Firefox Nightly" (63.0a1 - Build ID 20180812220618) installed. Now the "Pocket" icon is solid after a website is added to "Pocket".