Closed Bug 1463082 Opened Last year Closed Last year

Port Bug 1361387 "Update callsites of loadURI() within browser/ to pass a triggeringPrincipal" to SeaMonkey

Categories

(SeaMonkey :: General, enhancement)

SeaMonkey 2.52 Branch
enhancement
Not set

Tracking

(seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.58 wontfix, seamonkey2.59 wontfix, seamonkey2.60 fixed)

RESOLVED FIXED
seamonkey2.60
Tracking Status
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed
seamonkey2.58 --- wontfix
seamonkey2.59 --- wontfix
seamonkey2.60 --- fixed

People

(Reporter: frg, Assigned: frg)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 5 obsolete files)

+++ This bug was initially created as a clone of Bug #1379369 +++

While investigating load failures with an old sessionstore.json file on some websites I saw that we missed the fix for bug 1359092.
The actual bug which implemente this in browser was Bug 1361387.
Summary: Port Bug 1359092 "Extend loadURI within nsIWebNavigation.idl by a triggeringPrincipal argument" to SeaMonkey → Port Bug 1361387 "Update callsites of loadURI() within browser/ to pass a triggeringPrincipal" to SeaMonkey
Attached patch 1463082-loaduri-253.patch (obsolete) — Splinter Review
2.53 version
Attached file old .json testcase (obsolete) —
Some related triggeringprincipal cleanup in the sessionstore but I could also move it to a separate bug. So far was too lazy :) 2.53
Attached patch 1463082-loaduri.patch (obsolete) — Splinter Review
For 2.57 and up. 2.57 feeds is broken but the sessionrestore worked with it.
Attachment #8979324 - Flags: review?(iann_bugzilla)
Attachment #8979324 - Flags: approval-comm-esr60?
and the cleanup patch
Attachment #8979325 - Flags: review?(iann_bugzilla)
Attachment #8979325 - Flags: approval-comm-esr60?
Attached patch 1463082-loaduri.patch (obsolete) — Splinter Review
Another minor fix for bad sessionrestore.json files.

curSHEntry was added in Bug 549573 but is now unused and can throw because outside the subsequent try block.
Attachment #8979324 - Attachment is obsolete: true
Attachment #8979324 - Flags: review?(iann_bugzilla)
Attachment #8979324 - Flags: approval-comm-esr60?
Attachment #8980973 - Flags: review?(iann_bugzilla)
Attachment #8980973 - Flags: approval-comm-esr60?
Attached patch 1463082-loaduri-253.patch (obsolete) — Splinter Review
2.53 version
Attachment #8979199 - Attachment is obsolete: true
Comment on attachment 8980973 [details] [diff] [review]
1463082-loaduri.patch

I need to look into this further
Attachment #8980973 - Flags: review?(iann_bugzilla)
Attachment #8980973 - Flags: approval-comm-esr60?
Sessionrestore generally seems to fail with many tabs in the sessionstore.json. This needs to be fixed for 2.57. Not sure if this is the right bug here yet but lets block 2.57 to keep track.
Comment on attachment 8979325 [details] [diff] [review]
1463082-sessionstore.patch

LGTM r/a=me
Attachment #8979325 - Flags: review?(iann_bugzilla)
Attachment #8979325 - Flags: review+
Attachment #8979325 - Flags: approval-comm-esr60?
Attachment #8979325 - Flags: approval-comm-esr60+
Only ports bug 1361387. The sessionstore load faile will need to be taken care of in another bug.
Attachment #8980973 - Attachment is obsolete: true
Attachment #8983528 - Flags: review?(iann_bugzilla)
Attachment #8983528 - Flags: approval-comm-esr60?
2.53 version
Attachment #8980974 - Attachment is obsolete: true
Blocks: 1466911
Attachment #8979259 - Attachment is obsolete: true
Comment on attachment 8983528 [details] [diff] [review]
1463082-loaduri.patch

LGTM r/a=me
Attachment #8983528 - Flags: review?(iann_bugzilla)
Attachment #8983528 - Flags: review+
Attachment #8983528 - Flags: approval-comm-esr60?
Attachment #8983528 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/3e2a160047f2
Update callsites of webNavigation.loadURI() in suite to pass a triggeringPrincipal. r=IanN
https://hg.mozilla.org/comm-central/rev/fbb92128d855
Remove try from deserializePrincipal because it no longer throws. r=IanN
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.