Closed
Bug 1463082
Opened 6 years ago
Closed 6 years ago
Port Bug 1361387 "Update callsites of loadURI() within browser/ to pass a triggeringPrincipal" to SeaMonkey
Categories
(SeaMonkey :: General, enhancement)
Tracking
(seamonkey2.58 wontfix, seamonkey2.59 wontfix, seamonkey2.60 fixed, seamonkey2.53 fixed, seamonkey2.57esr fixed)
RESOLVED
FIXED
seamonkey2.60
People
(Reporter: frg, Assigned: frg)
References
(Blocks 1 open bug)
Details
Attachments
(4 files, 5 obsolete files)
|
2.34 KB,
patch
|
Details | Diff | Splinter Review | |
|
2.32 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
8.08 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
8.30 KB,
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1379369 +++ While investigating load failures with an old sessionstore.json file on some websites I saw that we missed the fix for bug 1359092.
|
Assignee | |
Comment 1•6 years ago
|
||
The actual bug which implemente this in browser was Bug 1361387.
Summary: Port Bug 1359092 "Extend loadURI within nsIWebNavigation.idl by a triggeringPrincipal argument" to SeaMonkey → Port Bug 1361387 "Update callsites of loadURI() within browser/ to pass a triggeringPrincipal" to SeaMonkey
|
|
Assignee | |
Comment 2•6 years ago
|
||
2.53 version
|
|
Assignee | |
Comment 4•6 years ago
|
||
Some related triggeringprincipal cleanup in the sessionstore but I could also move it to a separate bug. So far was too lazy :) 2.53
|
|
Assignee | |
Comment 5•6 years ago
|
||
For 2.57 and up. 2.57 feeds is broken but the sessionrestore worked with it.
Attachment #8979324 -
Flags: review?(iann_bugzilla)
Attachment #8979324 -
Flags: approval-comm-esr60?
|
|
Assignee | |
Comment 6•6 years ago
|
||
and the cleanup patch
Attachment #8979325 -
Flags: review?(iann_bugzilla)
Attachment #8979325 -
Flags: approval-comm-esr60?
|
|
Assignee | |
Comment 7•6 years ago
|
||
Another minor fix for bad sessionrestore.json files. curSHEntry was added in Bug 549573 but is now unused and can throw because outside the subsequent try block.
Attachment #8979324 -
Attachment is obsolete: true
Attachment #8979324 -
Flags: review?(iann_bugzilla)
Attachment #8979324 -
Flags: approval-comm-esr60?
Attachment #8980973 -
Flags: review?(iann_bugzilla)
Attachment #8980973 -
Flags: approval-comm-esr60?
|
|
Assignee | |
Comment 9•6 years ago
|
||
Comment on attachment 8980973 [details] [diff] [review] 1463082-loaduri.patch I need to look into this further
Attachment #8980973 -
Flags: review?(iann_bugzilla)
Attachment #8980973 -
Flags: approval-comm-esr60?
|
|
Assignee | |
Comment 10•6 years ago
|
||
Sessionrestore generally seems to fail with many tabs in the sessionstore.json. This needs to be fixed for 2.57. Not sure if this is the right bug here yet but lets block 2.57 to keep track.
Blocks: 2.57BulkMalfunctions
|
||
Comment 11•6 years ago
|
||
Comment on attachment 8979325 [details] [diff] [review] 1463082-sessionstore.patch LGTM r/a=me
Attachment #8979325 -
Flags: review?(iann_bugzilla)
Attachment #8979325 -
Flags: review+
Attachment #8979325 -
Flags: approval-comm-esr60?
Attachment #8979325 -
Flags: approval-comm-esr60+
|
|
Assignee | |
Comment 12•6 years ago
|
||
Only ports bug 1361387. The sessionstore load faile will need to be taken care of in another bug.
Attachment #8980973 -
Attachment is obsolete: true
Attachment #8983528 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8983528 -
Flags: approval-comm-esr60?
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8979259 -
Attachment is obsolete: true
|
|
||
Comment 14•6 years ago
|
||
Comment on attachment 8983528 [details] [diff] [review] 1463082-loaduri.patch LGTM r/a=me
Attachment #8983528 -
Flags: review?(iann_bugzilla)
Attachment #8983528 -
Flags: review+
Attachment #8983528 -
Flags: approval-comm-esr60?
Attachment #8983528 -
Flags: approval-comm-esr60+
|
||
Comment 15•6 years ago
|
||
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/3e2a160047f2 Update callsites of webNavigation.loadURI() in suite to pass a triggeringPrincipal. r=IanN https://hg.mozilla.org/comm-central/rev/fbb92128d855 Remove try from deserializePrincipal because it no longer throws. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 16•6 years ago
|
||
loaduri patch: https://hg.mozilla.org/releases/comm-esr60/rev/a61464d192162b2b7d6a1f63c11e13c77b8a3826 sessionstore patch: https://hg.mozilla.org/releases/comm-esr60/rev/cfa7d36686e82df9e41c2d4f65923c73b7c9ac09
status-seamonkey2.60:
--- → fixed
Target Milestone: --- → seamonkey2.60
|
|
Assignee | |
Comment 17•4 years ago
|
||
Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/f3d4150b9495729893b95c691f06cc5494a2fbbb
Update callsites of webNavigation.loadURI() in suite to pass a triggeringPrincipal.
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/4ffa72a45e6b813a2e019d6c79fb8cb47edbe657
Remove try from deserializePrincipal because it no longer throws.
You need to log in
before you can comment on or make changes to this bug.
Description
•