1463179 - The "toolbarpaletteitem" bindings will be removed from the "toolkit" folder

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[:Paolo Amadini]

The "toolbarpaletteitem" bindings will be removed from the "toolkit" folder. These may be unused, since there is another version of "toolbar.xml" in the tree, but if they are user they can be moved to comm-central.

Comment 1

[Richard Marti (:Paenglab)]

Thank you for the heads up, Paolo.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: toolbarpaletteitem.patch

This patch uses the bindings we have in our toolbar.xml.

Jörg, the m-c patch is in m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/06bdb8c0ced8 and lands probably on the next merge. Without our patch the customization will be busted.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8979704 [details] [diff] [review]
toolbarpaletteitem.patch

Review of attachment 8979704 [details] [diff] [review]:
-----------------------------------------------------------------

Have you tested this with the M-C patch applied?

The commit message should mention the M-C bug. I can add that, bug 1450816.

::: mail/base/content/bindings.css
@@ +33,5 @@
> +}
> +
> +toolbarpaletteitem[place="palette"] {
> +  -moz-box-orient: vertical;
> +  -moz-binding: url("chrome://messenger/content/toolbar.xml#toolbarpaletteitem-palette");

That's different to what M-C do:
 toolbarpaletteitem[place="palette"] {
-  -moz-binding: url("chrome://global/content/bindings/toolbar.xml#toolbarpaletteitem-palette-wrapping-label");
+  -moz-box-orient: vertical;
   width: 7em;
   /* icon (16) + margin (9 + 12) + 3 lines of text: */
   height: calc(39px + 3em);
   margin-bottom: 5px;
   margin-inline-end: 24px;
   overflow: visible;
   display: inline-block;
   vertical-align: top;
 }

That's intentional, yes?

Comment 4

[Richard Marti (:Paenglab)]

Yes. I'm adding in bindings.css only the removal of https://hg.mozilla.org/integration/mozilla-inbound/diff/06bdb8c0ced8/toolkit/content/xul.css.

The browser palette is different to our one. It's for their AppMenu.

Comment 5

[Jorg K (CEST = GMT+2)]

Sorry, I missed the merge. I'll wait to see whether the Daily run shows test failures. I'll also do a local to check whether the patch fixes the failures, if any. I can also trigger a new Daily run.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/51678c5b0b3e
Restore the "toolbarpaletteitem" binding after its removal in M-C in bug 1450816. r=jorgk