146321 - implement File Menu: Send Link

Status: VERIFIED FIXED

(Camino Graveyard :: Toolbars & Menus, enhancement)

Description

[Winnie Lam]

"File Menu: Send Link" should be greyed out if no current window is open.  Maybe
related to external protocol support (bug 145807).

Comment 1

[saari (gone)]

->sdagley

Comment 2

[Steve Dagley]

Not related to external protocol support.  Should be handled by whatever
listener updates the state of the menu items when a window opens/closes/loads a
new page

Comment 3

[Winnie Lam]

Test cases for Navigator file menu:
http://www.mozilla.org/quality/browser/front-end/testcases/menus/#file

Test cases for context menus in general:
http://www.mozilla.org/quality/browser/front-end/testcases/context-menus/

Comment 4

[Greg K.]

Using Chimera/20020602, no "Send Link" item is visible in the File menu.

Comment 5

[Steve Smart]

This was fixed long, long ago. I can't even remember the last build that had a
"Send Link" item.

Comment 6

[Greg K.]

Resolving Invalid since the menu item no longer apparently exists.

Comment 7

[Dave Barrowman]

Reopening - this is a key requirement.

Comment 8

[Greg K.]

So then this bug is actually about implementing Send Link, then, I take it.

Comment 9

[Steve Smart]

I think it should be up to Pinkerton whether or not we're going to have this
menu item if that's what this bug is about now. I hardly think it is a key
requirement since you can do the exact same thing by typing cmd-L and choosing
Services>Mail>Mail Text.

Comment 10

[Dave Barrowman]

Yes - the original desrciption does not make that clear.  The product should
implement the ability to launch the default mail app with the current URL
prepopulated in the message body.

Comment 11

[Dave Barrowman]

Typing cmd-L and choosing Services>Mail>Mail Text does indeed accomplish the
same thing but it requires the user to select the URL before going to a menu
three levels deep.  

A top level menu item would make this capability more discoverable and easier to
use (one step rather than two).

Comment 12

[sairuh (rarely reading bugmail)]

i think effectively implementing Services could possibly eliminate adding this
menu item --see bug 152023 comment 6.

Comment 13

[Steve Dagley]

Setting to an RFE and asking what's the current opinion on whether or not we'd
actually want this as a top level menu item rather than a Services item?

Comment 14

[Lauri Kieksi]

It'd be almost like having a Chimera-specific variant of the Copy command,
except much less useful. The Mail service provides this functionality in a
system-wide fashion, through an operation that works the same in all apps that
support services.

And so what if it's not a top level menu command? Should it even be one? No.
Sending a link over e-mail is something that people don't want/need to do as
frequently as they open or close windows/tabs. Making the File menu longer with
an item whose functionality is already available and one that isn't actually all
that important in the first place seems a tad silly to me.

Comment 15

[Greg K.]

*** Bug 171724 has been marked as a duplicate of this bug. ***

Comment 16

[sairuh (rarely reading bugmail)]

i agree with lauri. i don't think this should be yet another toplevel menu item.
(context menus are another case --see bug 166958.) once services are
implemented, that should suffice.

recommend WONTFIX.

Comment 17

[Joseph Feld]

Services only work with Apple's Mail.app, and are unavailable if it is not on
the user's system, or if the user has never configured it.  Mail's services also
do not place the page title in the subject header, as do IE and Mozilla.  I
don't believe that services adequately provide this functionality.

Comment 18

[Joseph Feld]

Attachment: Proposed patch for Send Link

Comment 19

[Steve Dagley]

Joseph, thanks for the patch

-> pinkerton for consideration

Comment 20

[Mike Pinkerton (not reading bugmail)]

i think this is probably worth considering. it does make sense to have something
like this.

Comment 21

[sairuh (rarely reading bugmail)]

->simon?

services has been implemented, but it turns out that sending the url (or page)
is not directly available from the services menu. instead, it'd take the user
two steps to accomplish this (select urlbar, the select mail under services).

as things stand now, i'm backing down from my comment 16 --having the File >
Send Link menu item would provide a good 1-step method to accomplish this task.

Comment 22

[Simon Fraser [no longer active]]

I checked in the patch, with some fixes. Thanks!

Comment 23

[kaldari]

Verified fixed in Chimera 2002111912.