152023 - Implement Services Menu

Status: VERIFIED FIXED

(Camino Graveyard :: OS Integration, enhancement)

Description

[Albert Kammerer]

I am using Mac OS X (10.1.5) and Navigator 0.3.0 (15 June). An enhancement was
submitted suggesting implementing "Open this URL in Navigator" in the Services
Menu. Not only do I think this is a great idea, but text services should also be
implemented. My best examples of this would be "Mail Text" and "Mail To" in Mail
and "Open Selection" in TextEdit. None of these menu items work in Navigator.
They are very useful for sending or saving text clippings from pages without
having to save/send the entire page. I used this feature all the time in OmniWeb.

Comment 1

[saari (gone)]

->sdagley

Comment 2

[Winnie Lam]

*** Bug 153708 has been marked as a duplicate of this bug. ***

Comment 3

[Winnie Lam]

Adding that this bug blocks bug 154286 - chimera UI polish issues.

Comment 4

[Mike Pinkerton (not reading bugmail)]

i really don't think this blocks polish. most users don't really expect the
services menu to work.

where is there documentation on what needs to be done to allow our view to be
service-savvy?

Comment 5

[Lauri Kieksi]

http://developer.apple.com/techpubs/macosx/Cocoa/TasksAndConcepts/ProgrammingTopics/SysServices/SysServices.html
http://developer.apple.com/techpubs/macosx/Cocoa/TasksAndConcepts/ProgrammingTopics/SysServices/Tasks/using.html

While I don't think lack of Services in the browser view is blocking Chimera UI
polish, I do think Services support would be a great improvement. I've heard
that Jaguar will feature a Services menu in context menus, so Services will be
more discoverable and accessible, which in turn will make users expect better
Services support in applications.

Comment 6

[sairuh (rarely reading bugmail)]

i was looking at the Mail items under the Services menus, and had a thought:
afaik, Services work on only selections, right? how about when Services are
implemented, that within Chimera --in additon to selections-- they'd work for
the current URL (current page or tab displayed)? and, even better for
accessibility reasons, having services work on the focused item in the page/tab
(eg, link or image).

this would eliminate adding extra menu items under the File, such as Send Link
suggested in bug 146321.

Comment 7

[Simon Fraser [no longer active]]

We need to have a way to get the content selection as text for this.

Comment 8

[Steve Dagley]

-> sfraser

Comment 9

[Simon Fraser [no longer active]]

*** Bug 158769 has been marked as a duplicate of this bug. ***

Comment 10

[Simon Fraser [no longer active]]

Patch coming

Comment 11

[Simon Fraser [no longer active]]

Attachment: Patch to implement services support for getting and inserting text

This patch adds support for services that get the selected text, and can insert
text. Currently, services are supported in BrowserWindowController, but that
will move to CHBrowserView.

The patch uses commands to communicate with gecko. I had to implement a
cmd_getContents, and hook up an insertText in the editor to a new command.

nsGlobalWindow implements the controller for those commands, and had to
implement nsICommandController so that we can use commands with params to pass
strings back and forth. global window calls nsIContentViewerEdit.

nsIContentViewerEdit was changed to add a getContents() and canGetContents().

nsIContentViewerEdit is implemented by nsDocumentViewer (and nsPluginViewer),
which needed impls of GetContents and GetCanGetContents. It turns around and
calls the presShell for those, so nsIPresShell required a new DoGetContents().
Its impl then calls into nsCopySupport, where I added a GetContents().

The insert/can insert commands go to editor. nsIPlaintextEditor needed a
canInsertText(). The insertText command calls into an existing
nsIPlaintextEditor method. nsEditorController had to be changed to implement
nsICommandController as well.

Comment 12

[Simon Fraser [no longer active]]

Patch checked in, moving the services code into CHBrowserView. When testing, be
sure to test services that both get the selected text (e.g. "Make New Sticky
Note"), and those that want to insert text (sample app available on request).

Comment 13

[Chris Petersen]

Marking verified in the 2002-11-15-04 NB under 10.2.2. The following services work:

Mail (Send Selection, Send to)
Make new Sticky Note
Speech (Start speaking Text, Stop Speaking)
Summarize
Text Edit (Open selection)
View in JavaBrowser

Comment 14

[Lewis Francis]

Services fail to work on selection when selected text is in a form field.
Instead, the entire fields contents are passed to the service.  New bug or
reopen this one? 

Comment 15

[Simon Fraser [no longer active]]

New bug please.

Comment 16

[Prachi Gauriar]

I believe this broke upon merging with the trunk.  The Services menu doesn't
work anymore with text selected in the BrowserView.

Comment 17

[sairuh (rarely reading bugmail)]

this is already covered by bug 196704, so i think this can be resolved.