1463315 - Should use nsIProfiler.getProfileDataAsArrayBuffer instead of getProfileDataAsync

Status: NEW

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

Description

[Markus Stange [:mstange]]

https://searchfox.org/mozilla-central/rev/2aa42f2cab4a110edf21dd7281ac23a1ea8901f9/devtools/server/actors/perf.js#95

Getting the profile as an array buffer has better performance because we won't materialize the JS objects for the JSON contents until the profile has arrived inside perf.html.

Comment 1

[Julien Wajsberg [:julienw]]

Is getProfileDataAsArrayBuffer async as well ?

Comment 2

[Markus Stange [:mstange]]

Yes it is. We should probably take a pass through nsIProfiler at some point and rename the methods to be consistent. When I added getProfileDataAsArrayBuffer, the idea was that "async" shouldn't need to be mentioned because async behavior should be assumed by default.