1463427 - When the old debugger is removed we should tidy the strings up

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We have a bunch of keys in the various properties files like this:
breakpointMenuItem.deleteAll.accesskey=a
breakpointMenuItem.deleteAll2.accesskey=a
breakpointMenuItem.deleteOthers.accesskey=h
breakpointMenuItem.deleteOthers2.accesskey=h

The keys relating to the old debugger should be removed.

Comment 1

[Erik Carrillo [:E_Carr]]

Hello Jason,

My name is Erik and I am an Outreachy candidate, could I please be assigned to this bug? Thanks.

Comment 2

[Erik Carrillo [:E_Carr]]

Hello Jason,

For this bug, should I only delete the keys mentioned in the Description/Comment 0?

breakpointMenuItem.deleteAll.accesskey=a
breakpointMenuItem.deleteAll2.accesskey=a
breakpointMenuItem.deleteOthers.accesskey=h
breakpointMenuItem.deleteOthers2.accesskey=h

Or should all the keys obtained from the following searchfox query:
https://searchfox.org/mozilla-central/search?q=breakpointMenuItem.delete&case=false&regexp=false&path=

Thank you in advance.

Comment 3

[Erik Carrillo [:E_Carr]]

Attachment: Bug 1463427 - When the old debugger is removed we should tidy the strings up. r=jlast

Comment 4

[Patrick Brosset <:pbro>]

Hi Jason, it looks like Erik was asking a question in comment 2 and has a patch up on phabricator. Could you please take a look at those?

Comment 5

[Jason Laster [:jlast]]

Thanks Patrick, Erik and I spoke in slack earlier.

It would be nice to remove all of the unused strings from the old debugger, which can be found by grepping or looking in searchfox.

Comment 6

[Jason Laster [:jlast]]

Erik, are you still interested in finishing this?

Comment 7

[David Walsh :davidwalsh]

Attachment: Bug 1463427 - Tidy up debugger strings r=jlast

I created a script (https://gist.github.com/darkwing/37ce7c59f937e36cba02fcb6711328bc) to find unused locale strings in the debugger.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33d246195bc0
Tidy up debugger strings r=jlast

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/33d246195bc0