Closed Bug 1463427 Opened Last year Closed 3 months ago

When the old debugger is removed we should tidy the strings up

Categories

(DevTools :: Debugger, enhancement, P3)

57 Branch
enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: miker, Assigned: davidwalsh, NeedInfo)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [debugger-reserve])

Attachments

(1 file, 1 obsolete file)

We have a bunch of keys in the various properties files like this:
breakpointMenuItem.deleteAll.accesskey=a
breakpointMenuItem.deleteAll2.accesskey=a
breakpointMenuItem.deleteOthers.accesskey=h
breakpointMenuItem.deleteOthers2.accesskey=h

The keys relating to the old debugger should be removed.
Target Milestone: --- → Future
Product: Firefox → DevTools
Summary: When the old debugger is used we should tidy the strings up → When the old debugger is removed we should tidy the strings up
No longer blocks: 1314057
Depends on: 1314057
Blocks: 1314057
No longer depends on: 1314057

Hello Jason,

My name is Erik and I am an Outreachy candidate, could I please be assigned to this bug? Thanks.

Assignee: nobody → ecarr3344
Status: NEW → ASSIGNED

Hello Jason,

For this bug, should I only delete the keys mentioned in the Description/Comment 0?

breakpointMenuItem.deleteAll.accesskey=a
breakpointMenuItem.deleteAll2.accesskey=a
breakpointMenuItem.deleteOthers.accesskey=h
breakpointMenuItem.deleteOthers2.accesskey=h

Or should all the keys obtained from the following searchfox query:
https://searchfox.org/mozilla-central/search?q=breakpointMenuItem.delete&case=false&regexp=false&path=

Thank you in advance.

Hi Jason, it looks like Erik was asking a question in comment 2 and has a patch up on phabricator. Could you please take a look at those?

Flags: needinfo?(jlaster)

Thanks Patrick, Erik and I spoke in slack earlier.

It would be nice to remove all of the unused strings from the old debugger, which can be found by grepping or looking in searchfox.

Flags: needinfo?(jlaster)

Erik, are you still interested in finishing this?

Flags: needinfo?(ecarr3344)
Assignee: ecarr3344 → nobody
Status: ASSIGNED → NEW
Priority: P2 → P3
Attachment #9051227 - Attachment is obsolete: true
Blocks: 1565711
Blocks: 1565713

I created a script (https://gist.github.com/darkwing/37ce7c59f937e36cba02fcb6711328bc) to find unused locale strings in the debugger.

Assignee: nobody → dwalsh
Blocks: dbg-70
Status: NEW → ASSIGNED
Whiteboard: [debugger-reserve]
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33d246195bc0
Tidy up debugger strings r=jlast
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: Future → Firefox 70
No longer blocks: 1565711
No longer blocks: 1565713
You need to log in before you can comment on or make changes to this bug.