1463917 - Use widget code to render scrollcorner

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1463917 part 1 - Add scrollcorner to -moz-appearance so that widget can render it.

Review commit: https://reviewboard.mozilla.org/r/251710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251710/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1463917 part 2 - Have windows widget render scrollcorner.

Review commit: https://reviewboard.mozilla.org/r/251712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251712/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Somehow resizer is supported automatically with scrollcorner be rendered through widget... Probably need some investigation on how it works, but it's great that it works without extra effort :D

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8986346 [details]
Bug 1463917 part 1 - Add scrollcorner to -moz-appearance so that widget can render it.

https://reviewboard.mozilla.org/r/251710/#review258092

::: toolkit/themes/osx/global/nativescrollbars.css:77
(Diff revision 1)
>  
>  scrollcorner {
> -  /* XXX -moz-appearance: scrollcorner; */
> +  -moz-appearance: scrollcorner;
>    width: 16px;
>    cursor: default;
>    background-color: white;

Is this background-color unnecessary now?

::: toolkit/themes/windows/global/xulscrollbars.css:69
(Diff revision 1)
>  
>  scrollcorner {
> -  /* XXX -moz-appearance: scrollcorner; */
> +  -moz-appearance: scrollcorner;
>    width: 16px;
>    cursor: default;
>    background-color: -moz-Dialog;

And here?

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8986346 [details]
Bug 1463917 part 1 - Add scrollcorner to -moz-appearance so that widget can render it.

https://reviewboard.mozilla.org/r/251710/#review258092

> Is this background-color unnecessary now?

Not until the new widget type is supported by the given platform, which in this case is macOS.

> And here?

Same here, but for Windows and Linux. We may need this even after all platforms support that, for the case when native theme is disabled. See bug 1469741.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8986346 [details]
Bug 1463917 part 1 - Add scrollcorner to -moz-appearance so that widget can render it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251710/diff/1-2/

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8986347 [details]
Bug 1463917 part 2 - Have windows widget render scrollcorner.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251712/diff/1-2/

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 8986347 [details]
Bug 1463917 part 2 - Have windows widget render scrollcorner.

https://reviewboard.mozilla.org/r/251712/#review258256

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1321b144616
part 1 - Add scrollcorner to -moz-appearance so that widget can render it. r=heycam
https://hg.mozilla.org/integration/autoland/rev/d69617c50c04
part 2 - Have windows widget render scrollcorner. r=jimm

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d1321b144616
https://hg.mozilla.org/mozilla-central/rev/d69617c50c04