make account wizard smart enough not to need window.alert

RESOLVED FIXED in seamonkey2.0a1

Status

RESOLVED FIXED
17 years ago
10 years ago

People

(Reporter: timeless, Assigned: neil)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.0a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

17 years ago
1. you should use prompt service (patch)
2. you shouldn't use any alert, instead the next button shouldn't be enabled 
until the user really can continue.
(Reporter)

Comment 1

17 years ago
Created attachment 84739 [details] [diff] [review]
use prompt service
(Assignee)

Comment 2

17 years ago
Created attachment 84919 [details] [diff] [review]
Only enable the Next > button when appropriate
(Reporter)

Updated

17 years ago
Attachment #84739 - Attachment is obsolete: true
(Assignee)

Comment 3

16 years ago
Created attachment 95263 [details] [diff] [review]
Updated as per timeless' comments
Attachment #84919 - Attachment is obsolete: true
(Reporter)

Updated

16 years ago
Attachment #95263 - Flags: review+
(Reporter)

Comment 4

16 years ago
=>neil
Assignee: racham → neil
Summary: account wizard nags using window.alert → make account wizard smart enough not to need window.alert

Comment 5

15 years ago
Neil: any update here or are the patched obsolete?
(Assignee)

Comment 6

15 years ago
Created attachment 126994 [details] [diff] [review]
Bitrot update

Updated

15 years ago
Attachment #126994 - Flags: superreview?(sspitzer)
Attachment #126994 - Flags: review?(sspitzer)
Product: Browser → Seamonkey

Comment 7

13 years ago
Comment on attachment 126994 [details] [diff] [review]
Bitrot update

I'll look at this -
Attachment #126994 - Flags: superreview?(sspitzer)
Attachment #126994 - Flags: superreview?(bienvenu)
Attachment #126994 - Flags: review?(sspitzer)
Attachment #126994 - Flags: review?(bienvenu)

Comment 8

13 years ago
oh my, that's quite old.  It's almost certainly bit-rotted again.

Comment 9

11 years ago
OK, it has bit-rotted. Do you have an unbit-rotted version? If not, I'll try to resurrect it.

Comment 10

11 years ago
ugh, sorry, the bit rot is a bit out of control, and the diffs are hard to read because of code moving around, so I'm going to mark this obsolete and hope Neil gives me yet an other chance :-(

Updated

11 years ago
Attachment #126994 - Attachment is obsolete: true
Attachment #126994 - Flags: superreview?(bienvenu)
Attachment #126994 - Flags: review?(bienvenu)
(Assignee)

Comment 11

11 years ago
Created attachment 322237 [details] [diff] [review]
Bitrot update

Unfortunately the patch now looks a little ugly in places, see what you think?
Attachment #95263 - Attachment is obsolete: true
Attachment #322237 - Flags: superreview?
(Assignee)

Updated

11 years ago
Attachment #322237 - Flags: superreview? → superreview?(bienvenu)

Comment 12

11 years ago
the patch looks OK - I just want to apply it and do some basic tests, since the account wizard doesn't get a lot of day to day testing in nightly builds :-)

Comment 13

11 years ago
Comment on attachment 322237 [details] [diff] [review]
Bitrot update

seems to work fine - I tried all four kinds of accounts (pop3, imap, gmail, and rss), and Next seem to be enabled appropriately.
Attachment #322237 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 14

11 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Blocks: 219509

Updated

10 years ago
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → seamonkey2.0alpha
You need to log in before you can comment on or make changes to this bug.