146392 - make account wizard smart enough not to need window.alert

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[timeless]

1. you should use prompt service (patch)
2. you shouldn't use any alert, instead the next button shouldn't be enabled 
until the user really can continue.

Comment 1

[timeless]

Attachment: use prompt service

Comment 2

[[e-mail]]

Attachment: Only enable the Next > button when appropriate

Comment 3

[[e-mail]]

Attachment: Updated as per timeless' comments

Comment 4

[timeless]

=>neil

Comment 5

[Henrik Gemal]

Neil: any update here or are the patched obsolete?

Comment 6

[[e-mail]]

Attachment: Bitrot update

Comment 7

[David :Bienvenu]

Comment on attachment 126994 [details] [diff] [review]
Bitrot update

I'll look at this -

Comment 8

[David :Bienvenu]

oh my, that's quite old.  It's almost certainly bit-rotted again.

Comment 9

[David :Bienvenu]

OK, it has bit-rotted. Do you have an unbit-rotted version? If not, I'll try to resurrect it.

Comment 10

[David :Bienvenu]

ugh, sorry, the bit rot is a bit out of control, and the diffs are hard to read because of code moving around, so I'm going to mark this obsolete and hope Neil gives me yet an other chance :-(

Comment 11

[[e-mail]]

Attachment: Bitrot update

Unfortunately the patch now looks a little ugly in places, see what you think?

Comment 12

[David :Bienvenu]

the patch looks OK - I just want to apply it and do some basic tests, since the account wizard doesn't get a lot of day to day testing in nightly builds :-)

Comment 13

[David :Bienvenu]

Comment on attachment 322237 [details] [diff] [review]
Bitrot update

seems to work fine - I tried all four kinds of accounts (pop3, imap, gmail, and rss), and Next seem to be enabled appropriately.

Comment 14

[[e-mail]]

Fix checked in.