Closed Bug 146392 Opened 22 years ago Closed 16 years ago

make account wizard smart enough not to need window.alert

Categories

(SeaMonkey :: MailNews: Account Configuration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: timeless, Assigned: neil)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 4 obsolete files)

1. you should use prompt service (patch)
2. you shouldn't use any alert, instead the next button shouldn't be enabled 
until the user really can continue.
Attached patch use prompt service (obsolete) — Splinter Review
Attachment #84739 - Attachment is obsolete: true
Attachment #84919 - Attachment is obsolete: true
Attachment #95263 - Flags: review+
=>neil
Assignee: racham → neil
Summary: account wizard nags using window.alert → make account wizard smart enough not to need window.alert
Neil: any update here or are the patched obsolete?
Attached patch Bitrot update (obsolete) — Splinter Review
Attachment #126994 - Flags: superreview?(sspitzer)
Attachment #126994 - Flags: review?(sspitzer)
Product: Browser → Seamonkey
Comment on attachment 126994 [details] [diff] [review]
Bitrot update

I'll look at this -
Attachment #126994 - Flags: superreview?(sspitzer)
Attachment #126994 - Flags: superreview?(bienvenu)
Attachment #126994 - Flags: review?(sspitzer)
Attachment #126994 - Flags: review?(bienvenu)
oh my, that's quite old.  It's almost certainly bit-rotted again.
OK, it has bit-rotted. Do you have an unbit-rotted version? If not, I'll try to resurrect it.
ugh, sorry, the bit rot is a bit out of control, and the diffs are hard to read because of code moving around, so I'm going to mark this obsolete and hope Neil gives me yet an other chance :-(
Attachment #126994 - Attachment is obsolete: true
Attachment #126994 - Flags: superreview?(bienvenu)
Attachment #126994 - Flags: review?(bienvenu)
Attached patch Bitrot updateSplinter Review
Unfortunately the patch now looks a little ugly in places, see what you think?
Attachment #95263 - Attachment is obsolete: true
Attachment #322237 - Flags: superreview?
Attachment #322237 - Flags: superreview? → superreview?(bienvenu)
the patch looks OK - I just want to apply it and do some basic tests, since the account wizard doesn't get a lot of day to day testing in nightly builds :-)
Comment on attachment 322237 [details] [diff] [review]
Bitrot update

seems to work fine - I tried all four kinds of accounts (pop3, imap, gmail, and rss), and Next seem to be enabled appropriately.
Attachment #322237 - Flags: superreview?(bienvenu) → superreview+
Fix checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → seamonkey2.0alpha
You need to log in before you can comment on or make changes to this bug.