219509 - undeclared variable and using alert instead of the promptservice

Status: NEW

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[timeless]

@see bug 138302 

chrome://messenger/content/AccountWizard.js line 87: assignment to undeclared
variable gDefaultSpecialFolderPickerMode

###!!! ASSERTION: You are calling CreateInstance
"{a2112d6a-0e28-421f-b46a-25c0b308cbd0}" when a service for this CID already
exists!: 'Error', file i:/build/mozilla/xpcom/components/nsComponentManager.cpp,
line 1952

Comment 1

[timeless]

Attachment: declare variable and use the promptservice

Comment 2

[[e-mail]]

Comment on attachment 131625 [details] [diff] [review]
declare variable and use the promptservice

>-var promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService();
>-promptService = promptService.QueryInterface(Components.interfaces.nsIPromptService);
>+var promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService(Components.interfaces.nsIPromptService);
Nit: const

> // default picker mode for copies and folders
>-gDefaultSpecialFolderPickerMode = "0";
>+var gDefaultSpecialFolderPickerMode = "0";
hmmm... const, really...

>+var gPromptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"].
>+                     getService(Components.interfaces.nsIPromptService);
Redeclaration, surely?

>+function Alert(alertText){
>+gPromptService.alert(document.window, document.title, alertText);
>+}
document.window? I don't think that's defined, just use window.

>-    var alertText = gPrefsBundle.getString("enterName");
>-    window.alert(alertText);
>+    Alert(gPrefsBundle.getString("enterName"));
Nice cleanup but you could rename the method and move the getString into it.

What about the other aw-*.js, did you forget to diff them?

Comment 3

[Stefan Borggraefe]

The undeclared variable part of this bug is already fixed.

window.alert is still used in:
/mailnews/base/prefs/resources/content/aw-accname.js
/mailnews/base/prefs/resources/content/aw-done.js
/mailnews/base/prefs/resources/content/aw-identity.js
/mailnews/base/prefs/resources/content/aw-login.js
/mailnews/base/prefs/resources/content/aw-server.js

Comment 4

[Stefan Borggraefe]

Attachment: Patch

This patch does the following:
1. Use promptservice instead of alert().
2. After a failed validity check, returns the focus to the element on which
   the check failed.
3. Corrects all JavaScript Warnings in the Account Wizard (there were a lot).

Comment 5

[Stefan Borggraefe]

Comment on attachment 145608 [details] [diff] [review]
Patch

Patch bitrotted.

Comment 6

[Serge Gautherie (:sgautherie)]

Could you check what is left of this bug (and patch) ?
(Now that bug 146392 is fixed.)

Comment 7

[[e-mail]]

AFAIK only the removal of the unused function from aw-done.js is left.