1464384 - Stop returning true/false from focusAndSelectUrlBar

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Dão Gottwald [:dao]]

This goes back to when the address bar could be removed from the toolbar. The address bar cannot be removed anymore, so the return value is always true -- except in non-browser windows on Mac.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ec13982b9e184c7e847a7da6bde902af893f4fa

Comment 1

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcb12a5347bbf0308559457807272d4b46a03d9e

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1464384 - Stop returning true/false from focusAndSelectUrlBar.

Review commit: https://reviewboard.mozilla.org/r/246730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246730/

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 8980582 [details]
Bug 1464384 - Stop returning true/false from focusAndSelectUrlBar.

https://reviewboard.mozilla.org/r/246730/#review252882

::: browser/base/content/browser.js:2300
(Diff revision 1)
> +    focusAndSelectUrlBar(true);
>      return;
> +  }
>  
> -  if (window.location.href != getBrowserURL()) {
> -    var win = getTopWin();
> +  // If there's an open browser window, redirect the command there.
> +  let win = getTopWin();

out of curiosity, is there a specific reason for getTopWin() in utilityOverlay, instead of being a  BrowserWindowTracker.getCurrentOrTopWindow()?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Marco Bonardo [::mak] from comment #3)
> Comment on attachment 8980582 [details]
> Bug 1464384 - Stop returning true/false from focusAndSelectUrlBar.
> 
> https://reviewboard.mozilla.org/r/246730/#review252882
> 
> ::: browser/base/content/browser.js:2300
> (Diff revision 1)
> > +    focusAndSelectUrlBar(true);
> >      return;
> > +  }
> >  
> > -  if (window.location.href != getBrowserURL()) {
> > -    var win = getTopWin();
> > +  // If there's an open browser window, redirect the command there.
> > +  let win = getTopWin();
> 
> out of curiosity, is there a specific reason for getTopWin() in
> utilityOverlay, instead of being a 
> BrowserWindowTracker.getCurrentOrTopWindow()?

getTopWin has direct access to the current window, BrowserWindowTracker doesn't.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85187fee1034
Stop returning true/false from focusAndSelectUrlBar. r=mak

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/85187fee1034