1464414 - Remove gURLBar null-check from XULBrowserWindow.setOverLink

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P5)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1464384 +++

This goes back to when the address bar could be removed from the toolbar. The address bar cannot be removed anymore, so gURLBar is always non-null in browsers windows and this null-check is now pointless:

https://searchfox.org/mozilla-central/rev/bf4def01bf8f6ff0d18f02f2d7e9efc73e12c63f/browser/base/content/browser.js#4628

Comment 1

[lucas05]

Can I work on this? :)

Comment 2

[Dão Gottwald [:dao]]

(In reply to lucas05 from comment #1)
> Can I work on this? :)

Sure!

Comment 3

[Manish [:manishkk]]

Are you still working on this?
If need any help, write here or ask in IRC.

(In reply to lucas05 from comment #1)
> Can I work on this? :)

Comment 4

[lucas05]

(In reply to Manish Kumar [:manishkk] from comment #3)
> Are you still working on this?
> If need any help, write here or ask in IRC.
> 
> (In reply to lucas05 from comment #1)
> > Can I work on this? :)

Yes. I know is an easy one :) I had little time, sorry. Either today or tomorrow I'll patch it!

Comment 5

[lucas05]

Attachment: Bug 1464414 - Remove gURLBar null-check from XULBrowserWindow.setOverLink

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8985800 [details] [diff] [review]
Bug 1464414 - Remove gURLBar null-check from XULBrowserWindow.setOverLink

>-      if (gURLBar && gURLBar._mayTrimURLs /* corresponds to browser.urlbar.trimURLs */)
>-        url = trimURL(url);
>+      url = trimURL(url);

We still need gURLBar._mayTrimURLs /* corresponds to browser.urlbar.trimURLs */. Only the "gURLBar &&" part can go.

Comment 7

[lucas05]

Attachment: "gURLBar &&" only removed from If statement

Here it is! I've fixed the patch :)

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8986687 [details] [diff] [review]
"gURLBar &&" only removed from If statement

Looks good, thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b18075d2be2
Remove gURLBar null-check from XULBrowserWindow.setOverLink. r=dao

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4b18075d2be2