1464467 - Position of "type" indicator is wrong in rtl for compact highlights

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Kate Hudson :k88hudson]

Attachment: rtl-wrong.png

The "type" indicator icon on compact highlights appears to be showing up always on the right, even in rtl; it should be on the left for rtl

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

oops. will fix nau

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4170

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5f90e88be2367c6e6a5ba5f148a7f73b4251eb1f
fix(highlights): Use offset-inline instead of left/right for icon types (#4170)

Fix Bug 1464467 - Position of "type" indicator is wrong in rtl for compact highlights

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/609a288fe314

Comment 5

[Ciprian Muresan [:cmuresan], Ecosystem QA]

The issue is no longer reproducible on the latest Nightly 62.0a1 (Build ID 20180604100129) on Windows 10 x64, Mac 10.13.4 and Arch Linux x64. The "type" indicator is now on the left on RTL locales.