Perform browser error reporting processing during idle

RESOLVED FIXED in Firefox 62

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: osmose, Assigned: osmose)

Tracking

Trunk
Firefox 62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

As per bug 1446817 comment 16, we should schedule the processing necessary for browser error reporting to happen when the browser is idle and has cycles to spare, as it's not vital to the user experience. John-Galt recommends using ChromeUtils.idleDispatch for this purpose.
Assignee: nobody → mkelly
Blocks: 1461439
Comment on attachment 8983464 [details]
Bug 1464521: Process collected browser JS errors during idle.

https://reviewboard.mozilla.org/r/249328/#review256004

Thanks

::: browser/modules/BrowserErrorReporter.jsm:202
(Diff revision 1)
>  
>      return "FILTERED";
>    }
>  
> -  async observe(message) {
> +  observe(message) {
> +    ChromeUtils.idleDispatch(() => this.handleMessage(message));

Maybe do `if (message instanceof Ci.nsIScriptError) { idleDispatch(); }` (and remove the QI call in handleMessage) just so we don't wind up creating idle tasks for messages that don't need to be processed
Attachment #8983464 - Flags: review?(kmaglione+bmo) → review+
Pushed by mkelly@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6d89c09bc10
Process collected browser JS errors during idle. r=kmag
https://hg.mozilla.org/mozilla-central/rev/e6d89c09bc10
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.