1464680 - Add WebRTC gn-configs for FreeBSD armv7 and OpenBSD aarch64

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Description

[Jan Beich]

Let's add more BSD configs even if untested in order to unblock Tier3 porting effort.

Comment 1

[Jan Beich]

Attachment: Bug 1464680 - Add more WebRTC's gn-configs for BSDs on ARM.

Based on output from FreeBSD armv7/aarch64.

Review commit: https://reviewboard.mozilla.org/r/247116/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247116/

Comment 2

[Jan Beich]

Comment on attachment 8980979 [details]
Bug 1464680 - Add more WebRTC's gn-configs for BSDs on ARM.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/247116/diff/1-2/

Comment 3

[Jan Beich]

(In reply to Jan Beich from comment #2)
> https://reviewboard.mozilla.org/r/247116/diff/1-2/

That was rebase after bug 1465274.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8980979 [details]
Bug 1464680 - Add more WebRTC's gn-configs for BSDs on ARM.

https://reviewboard.mozilla.org/r/247116/#review254566

Comment 5

[Jan Beich]

Comment on attachment 8980979 [details]
Bug 1464680 - Add more WebRTC's gn-configs for BSDs on ARM.

Approval Request Comment
[ESR consideration]: ESR52 -> ESR60 regression and ESR being easier to support on non-x86/x86_64 due to less code churn each release. The patch here is very large, so downstream maybe reluctant to backport it.
[Feature/Bug causing the regression]: bug 1393119 regression
[User impact if declined]: Broken build on NetBSD/OpenBSD non-x86/x86_64 and FreeBSD non-x86/x86_64/aarch64 unless --disable-webrtc. Of those only OpenBSD aarch64 has Rust support.
[Is this code covered by automated tests?]: Yes, by dom/media/ tests. Not on Tier3 platforms.
[Has the fix been verified in Nightly?]: Partially on ESR60. media/webrtc/ builds fine on FreeBSD armv7/aarch64 and there're no FreeBSD-specific changes, so results can be extrapolated to NetBSD and OpenBSD.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: bug 1465274 to fix merge conflict
[Is the change risky?]: No
[Why is the change risky/not risky?]: Can only break build
[String changes made/needed]: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8980979 [details]
Bug 1464680 - Add more WebRTC's gn-configs for BSDs on ARM.

Fixes build bustage for some Tier 3 platforms. Approved for 61.0b11 and ESR 60.1.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcfbe51f171e
Add more WebRTC's gn-configs for BSDs on ARM. r=chmanchester

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/125658aa0085

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/cfc0c17a7e4b

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dcfbe51f171e