Closed Bug 1465274 Opened 2 years ago Closed 2 years ago

webrtc compile failure on ppc64(le): g++: error: unrecognized command line option ‘-msse2'

Categories

(Firefox Build System :: General: Unsupported Platforms, defect, P5)

Other
Unspecified
defect

Tracking

(firefox-esr60 fixed, firefox61 fixed, firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: spectre, Assigned: spectre)

References

Details

Attachments

(1 file)

Spun off from bug 1434589 per request, though the fix here will necessarily fix that bug as well, at least on Linux.
Same patch as in that bug.
Assignee: nobody → spectre
Status: NEW → ASSIGNED
Attachment #8981683 - Flags: review?(nfroyd)
Comment on attachment 8981683 [details] [diff] [review]
Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux

Review of attachment 8981683 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #8981683 - Flags: review?(nfroyd) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/854d7b3f850d
Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux. r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/854d7b3f850d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
See Also: → 1434589
Comment on attachment 8981683 [details] [diff] [review]
Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:  bug 1393119 regression
User impact if declined: Broken build on Linux non-x86/x86_64 unless --disable-webrtc. Here's a list of affected architectures:
https://searchfox.org/mozilla-central/rev/38bcf897f1fa/media/webrtc/trunk/build/build_config.h#110-173
Fix Landed on Version: Firefox 62
Risk to taking this patch (and alternatives if risky): No, can only break build on Linux at worst.
String or UUID changes made by this patch: None
Attachment #8981683 - Flags: approval-mozilla-esr60?
Comment on attachment 8981683 [details] [diff] [review]
Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux

See comment 5. Probably less critical for non-ESR because rolling distributions rarely support non-x86/x86_64.
Attachment #8981683 - Flags: approval-mozilla-beta?
Comment on attachment 8981683 [details] [diff] [review]
Add ppc64 to webrtc, regenerate moz.build to remove SSE2 dependency for Linux

Needed for bug 1464680. Approved for 61.0b11 and ESR 60.1.
Attachment #8981683 - Flags: approval-mozilla-esr60?
Attachment #8981683 - Flags: approval-mozilla-esr60+
Attachment #8981683 - Flags: approval-mozilla-beta?
Attachment #8981683 - Flags: approval-mozilla-beta+
Priority: -- → P5
Duplicate of this bug: 1507052
You need to log in before you can comment on or make changes to this bug.