1464700 - Library button can't be clicked when animating

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Tim Nguyen :ntim]

STR:
1) bookmark something
2) dismiss the popup
3) click the library button while it's animating

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1464700 - fix animations making toolbarbuttons non-interactive, r?dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5b49c3b06d9
fix animations making toolbarbuttons non-interactive, r=dao

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b5b49c3b06d9

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: animation.gif

I reproduced the initial issue using Firefox 62.0a1 (20180527220122) on Windows 10x64.
While verifying this with Firefox 77.0b3 (20200507233245) I saw that the library button it's still not working while the Saved to Library message is displayed (on a new profile) and if the message is not displayed it's working well. Is this expected? Thanks!

Comment 6

[:Gijs (he/him)]

(In reply to Alexandru Trif, QA [:atrif] from comment #5)

Created attachment 9146744 [details]
animation.gif

I reproduced the initial issue using Firefox 62.0a1 (20180527220122) on Windows 10x64.
While verifying this with Firefox 77.0b3 (20200507233245) I saw that the library button it's still not working while the Saved to Library message is displayed (on a new profile) and if the message is not displayed it's working well. Is this expected? Thanks!

Not expected per se, can you file a follow-up bug for the confirmation hint? It may be tricky to fix for the same reasons I outlined in bug 1633430 comment 6 .

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

I opened bug 1636450. Then I think it's safe to close this bug as verified and continue in the other bug? Thanks!

Comment 8

[:Gijs (he/him)]

(In reply to Alexandru Trif, QA [:atrif] from comment #7)

I opened bug 1636450. Then I think it's safe to close this bug as verified and continue in the other bug? Thanks!

Yep, thank you!