1459907 - Implement new bookmark confirmation

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[Dão Gottwald [:dao]]

When saving a bookmark, flip the dialog like a card that says "Saved to your Library".

Amy, can you provide the spec for the animation?

Comment 1

[Dão Gottwald [:dao]]

Amy, are you going to work on this spec? Already working on it? Are you the wrong person to ask? Please respond to the needinfo rather than just cancelling it.

Comment 2

[Amy Lee [:amylee] UX]

Hi Dao, 

Really sorry I didn't realize I cancelled the NI, not sure how that happened. Aaron and I are meeting tomorrow to finalize the spec for you. I'll attach when ready.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1459907 - Implement new bookmark confirmation.

Review commit: https://reviewboard.mozilla.org/r/252056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252056/

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8986753 [details]
Bug 1459907 - Implement new bookmark confirmation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252056/diff/1-2/

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8986753 [details]
Bug 1459907 - Implement new bookmark confirmation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252056/diff/2-3/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8986753 [details]
Bug 1459907 - Implement new bookmark confirmation.

Aaron, can you give this a try and sign off on the user experience?

Windows build:
https://queue.taskcluster.net/v1/task/OJMczjPeT5emLrLr18czug/runs/0/artifacts/public/build/target.zip

Mac build:
https://queue.taskcluster.net/v1/task/C3L-eEndTkufdGruicTD0g/runs/0/artifacts/public/build/target.dmg

Linux build:
https://queue.taskcluster.net/v1/task/DqWAGY7pQvSwfXJQET5jKQ/runs/0/artifacts/public/build/target.tar.bz2

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8986753 [details]
Bug 1459907 - Implement new bookmark confirmation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252056/diff/3-4/

Comment 8

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=693ea0b4c2a1614e8ca6b7acdfc6f414eb4705bf

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8986753 [details]
Bug 1459907 - Implement new bookmark confirmation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252056/diff/4-5/

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 8986753 [details]
Bug 1459907 - Implement new bookmark confirmation.

Turns out Aaron isn't currently available.

Comment 11

[Marco Bonardo [:mak]]

Comment on attachment 8986753 [details]
Bug 1459907 - Implement new bookmark confirmation.

https://reviewboard.mozilla.org/r/252056/#review258848

::: browser/base/content/browser.js:8522
(Diff revision 5)
>    },
>  };
> +
> +var ConfirmationPanel = {
> +  /**
> +   * Shows the confirmation panel.

I would be nice to explain what is the "confirmation panel", maybe with a couple examples too, we have so many notifications and panels around...

Comment 12

[Dão Gottwald [:dao]]

I can add an explanation. Related too that, do you have ideas for a better name than "confirmation panel"? I'm not too happy with that myself.

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 8986753 [details]
Bug 1459907 - Implement new bookmark confirmation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252056/diff/5-6/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8939927a9b9
Implement new bookmark confirmation. r=mak

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b8939927a9b9

Comment 17

[gwarser]

Please respect toolkit.cosmeticAnimations.enabled;false

Comment 18

[Timea Cernea [:tbabos][inactive]]

Verified the new bookmark confirmation based on this video https://cl.ly/043u3C0p3W25 considering the "Saved to library" text in the latest Nightly 63.0a1 (2018-06-26)) version. On Windows 10 x64 and Mac OS X 10.1. it looks good. 
However, on Ubuntu 16.04. there is shadow that does not seem to be intended. Please check the attached screenshot.
 
Can you please confirm if the message on Ubuntu is incorrectly displayed?

Comment 19

[Timea Cernea [:tbabos][inactive]]

Attachment: Screenshot for Ubuntu

Comment 20

[Dão Gottwald [:dao]]

(In reply to Timea Babos from comment #18)
> However, on Ubuntu 16.04. there is shadow that does not seem to be intended. Please check the attached screenshot.
> 
> Can you please confirm if the message on Ubuntu is incorrectly displayed?

Indeed.

Comment 21

[Timea Cernea [:tbabos][inactive]]

I reported Bug 1471558 for the above mentioned issue regarding the message on Ubuntu.

I also checked on Firefox Beta 62.0b3 and the results are the same as mentioned in Comment 18.