Closed
Bug 1464785
Opened 6 years ago
Closed 6 years ago
Get rid of fake floating scrollbars on Windows, use native scrollbars, but style them using the new scroll-* properties
Categories
(DevTools :: Framework, enhancement, P3)
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: pbro, Assigned: jdescottes)
References
(Depends on 1 open bug)
Details
Attachments
(2 files)
|
6.19 KB,
patch
|
Details | Diff | Splinter Review | |
|
59 bytes,
text/x-review-board-request
|
pbro
:
review+
|
Details |
This was discussed in the following DevTools RFC: https://github.com/devtools-html/rfcs/issues/27 The outcome was that we would wait for the ability to style native scrollbars and stop using floating scrollbars on Windows. scrollbar-face-color and scrollbar-track-color are both in nithgly now. So we can do that. Here's a WIP patch that should do that, if someone wants to pick this up.
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
Assignee | |
Comment 1•6 years ago
|
||
On OSX, we use our custom floating scrollbars if the user is using a mouse or if they forced scrollbars in OSX Settings (General > Show scroll bars > Always). I guess Linux also uses it. Until scrollbar-face-color and scrollbar-track-color can be used on all platforms, we should keep using custom scrollbars for OSX and Linux.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8985515 [details] Bug 1464785 - Use native scrollbars in devtools dark theme for windows; https://reviewboard.mozilla.org/r/251110/#review258184 ::: devtools/client/themes/common.css:29 (Diff revision 2) > + scrollbar-face-color: var(--theme-body-color-inactive); > + scrollbar-track-color: var(--theme-splitter-color); We should only do this in the dark theme. The scrollbars on windows look ok with their default colors with the light theme.
Attachment #8985515 -
Flags: review?(pbrosset) → review+
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/78f117b43e0a Use native scrollbars in devtools dark theme for windows;r=pbro
|
||
Comment 7•6 years ago
|
||
Backed out changeset 78f117b43e0a (bug 1464785) for devtools failures on browser_parsable_css.js: Backout: https://hg.mozilla.org/integration/autoland/rev/ddc47948f3714ccae226d4079c859c7bce8daa22 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=78f117b43e0a8988506a0d524f9901d8ba654593&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&selectedJob=184915810 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=184915810&repo=autoland&lineNumber=1316 12:09:51 INFO - 23 INFO TEST-START | browser/base/content/test/static/browser_parsable_css.js 12:09:52 INFO - TEST-INFO | started process screenshot 12:09:52 INFO - TEST-INFO | screenshot: exit 0 12:09:52 INFO - <snipped 139 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test> 12:09:52 INFO - Buffered messages logged at 12:09:52 12:09:52 INFO - 24 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 25 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 26 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 27 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 28 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 29 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 30 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 31 INFO Ignored error "Error in parsing value for ‘display’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 32 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 33 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 34 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 35 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 36 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 37 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 38 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 39 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 40 INFO Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://devtools/client/debugger/new/dist/debugger.css because of whitelist item {"sourceName":"/devtools\\/client\\/debugger\\/new\\/dist\\/debugger.css/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 41 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 42 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 43 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 44 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 45 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 46 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 47 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 48 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 49 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 50 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 51 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 52 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 53 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 54 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 55 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 56 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 57 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 58 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 59 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 60 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 61 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 62 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 63 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 64 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 65 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 66 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 67 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 68 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 69 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 70 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 71 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 72 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 73 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 74 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 75 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 76 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 77 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 78 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 79 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 80 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 81 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 82 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 83 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 84 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 85 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 86 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 87 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 88 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 89 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 90 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 91 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 92 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 93 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 94 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 95 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 96 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 97 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 98 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 99 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 100 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 101 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 102 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 103 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 104 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 105 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 106 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 107 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 108 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 109 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 110 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 111 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 112 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 113 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 114 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 115 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 116 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 117 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 118 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 119 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 120 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 121 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 122 INFO Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’. Ruleset ignored due to bad selector." on resource://devtools/server/actors/highlighters.css because of whitelist item {"sourceName":"/highlighters\\.css$/i","errorMessage":"/Unknown pseudo-class.*moz-native-anonymous/i","isFromDevTools":true,"used":true} 12:09:52 INFO - 123 INFO Ignored error "Unknown property ‘-moz-border-radius’. Declaration dropped." on chrome://devtools/content/sourceeditor/codemirror/lib/codemirror.css because of whitelist item {"sourceName":"/codemirror\\.css$/i","isFromDevTools":true,"used":true} 12:09:52 INFO - Buffered messages finished 12:09:52 ERROR - 124 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for resource://devtools/client/themes/common.css: Unknown property ‘scrollbar-face-color’. Declaration dropped. -
Flags: needinfo?(jdescottes)
|
|
Assignee | |
Comment 8•6 years ago
|
||
xidorn: it looks like the way the test page is loaded in browser_parsable_css.js doesn't allow for scrollbar-*-color properties. https://searchfox.org/mozilla-central/rev/39b790b29543a4718d876d8ca3fd179d82fc24f7/browser/base/content/test/static/browser_parsable_css.js#336-350 Looking at the code it seems that we use a chrome privileged frame exactly for this kind of reason. Do you know if there is a specific limitation for scrollbar-*-color properties which would make them invalid in this setup?
Flags: needinfo?(jdescottes) → needinfo?(xidorn+moz)
|
||
Comment 9•6 years ago
|
||
It's a bit surprising. The common.css file is under resource: protocol, which is not supposed to have chrome priviledge, and thus the test is correct that it should be banned. The next question to me is why did it work for you? Are you testing the patch with layout.css.scrollbar-colors.enabled enabled? If so, you should turn that off, because that's off by default currently, and non-chrome stylesheet is not supposed to have it. If not, I'll need to take a closer look at why a resource: stylesheet is able to use chrome-only properties in this case then.
Flags: needinfo?(xidorn+moz) → needinfo?(jdescottes)
|
|
Assignee | |
Comment 10•6 years ago
|
||
Good catch! Looks like we tested with layout.css.scrollbar-colors.enabled :/ Will make another patch to address this.
Flags: needinfo?(jdescottes)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 12•6 years ago
|
||
Comment on attachment 8985515 [details] Bug 1464785 - Use native scrollbars in devtools dark theme for windows; Patrick, can you take another look? This time we move the properties to dark-theme.css which is loaded with chrome://
Attachment #8985515 -
Flags: review+ → review?(pbrosset)
|
|
Reporter | |
Comment 13•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8985515 [details] Bug 1464785 - Use native scrollbars in devtools dark theme for windows; https://reviewboard.mozilla.org/r/251110/#review259952 I tested this new patch on windows 10, this time making sure that the pref was cleared first! It works fine for me, the scrollbars are native and colors are nice with the dark theme.
Attachment #8985515 -
Flags: review?(pbrosset) → review+
|
|
Assignee | |
Comment 14•6 years ago
|
||
Thanks for testing Patrick! I locally checked that browser_parsable_css was passing with this new version + try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=c749cd0a643c2d6f771812fbfa4fa4a642e49461
|
||
Comment 15•6 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/86fcc230d64d Use native scrollbars in devtools dark theme for windows;r=pbro
|
||
Comment 16•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/86fcc230d64d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•