Rename Array.prototype.flatten to Array.prototype.flat

RESOLVED FIXED in Firefox 62

Status

()

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

11 months ago
flatten was renamed to flat to fix web compat problems with the original name.
(Assignee)

Updated

11 months ago
Assignee: nobody → evilpies
(Assignee)

Comment 2

11 months ago
(Assignee)

Comment 3

11 months ago
Comment on attachment 8981391 [details] [diff] [review]
Update test262. r?

I had to fiddle around a bit to get the renaming correctly record, but I think I got it now.
Attachment #8981391 - Flags: review?(andrebargull)
(Assignee)

Updated

11 months ago
Attachment #8981390 - Flags: review?(andrebargull)
Comment on attachment 8981390 [details] [diff] [review]
Rename Array.prototype.flatten to Array.prototype.flat

Review of attachment 8981390 [details] [diff] [review]:
-----------------------------------------------------------------

https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/js/xpconnect/tests/chrome/test_xrayToJS.xul#206 probably needs to be updated, too.
Attachment #8981390 - Flags: review?(andrebargull) → review+
Comment on attachment 8981391 [details] [diff] [review]
Update test262. r?

Review of attachment 8981391 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/js/src/tests/jstests.list#51 updated to use the new name. Thanks!

Updated

11 months ago
Attachment #8981391 - Flags: review?(andrebargull) → review+

Comment 6

11 months ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e44345b44d4e
Update test262. r=anba
https://hg.mozilla.org/integration/mozilla-inbound/rev/516dc753d654
Rename Array.prototype.flatten to Array.prototype.flat. r=anba
(Assignee)

Updated

11 months ago
Blocks: 1443630

Comment 7

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e44345b44d4e
https://hg.mozilla.org/mozilla-central/rev/516dc753d654
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Depends on: 1465396
You need to log in before you can comment on or make changes to this bug.