Closed
Bug 1465039
Opened 6 years ago
Closed 6 years ago
Rename Array.prototype.flatten to Array.prototype.flat
Categories
(Core :: JavaScript: Standard Library, enhancement)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
()
Details
Attachments
(2 files)
1.10 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
26.68 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
flatten was renamed to flat to fix web compat problems with the original name.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → evilpies
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 8981391 [details] [diff] [review] Update test262. r? I had to fiddle around a bit to get the renaming correctly record, but I think I got it now.
Attachment #8981391 -
Flags: review?(andrebargull)
Assignee | ||
Updated•6 years ago
|
Attachment #8981390 -
Flags: review?(andrebargull)
Comment 4•6 years ago
|
||
Comment on attachment 8981390 [details] [diff] [review] Rename Array.prototype.flatten to Array.prototype.flat Review of attachment 8981390 [details] [diff] [review]: ----------------------------------------------------------------- https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/js/xpconnect/tests/chrome/test_xrayToJS.xul#206 probably needs to be updated, too.
Attachment #8981390 -
Flags: review?(andrebargull) → review+
Comment 5•6 years ago
|
||
Comment on attachment 8981391 [details] [diff] [review] Update test262. r? Review of attachment 8981391 [details] [diff] [review]: ----------------------------------------------------------------- r+ with https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/js/src/tests/jstests.list#51 updated to use the new name. Thanks!
Updated•6 years ago
|
Attachment #8981391 -
Flags: review?(andrebargull) → review+
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e44345b44d4e Update test262. r=anba https://hg.mozilla.org/integration/mozilla-inbound/rev/516dc753d654 Rename Array.prototype.flatten to Array.prototype.flat. r=anba
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e44345b44d4e https://hg.mozilla.org/mozilla-central/rev/516dc753d654
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•