1465039 - Rename Array.prototype.flatten to Array.prototype.flat

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement)

Description

[Tom S. (please needinfo tschuster)]

flatten was renamed to flat to fix web compat problems with the original name.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Rename Array.prototype.flatten to Array.prototype.flat

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Update test262. r?

Comment 3

[Tom S. (please needinfo tschuster)]

Comment on attachment 8981391 [details] [diff] [review]
Update test262. r?

I had to fiddle around a bit to get the renaming correctly record, but I think I got it now.

Comment 4

[André Bargull [:anba]]

Comment on attachment 8981390 [details] [diff] [review]
Rename Array.prototype.flatten to Array.prototype.flat

Review of attachment 8981390 [details] [diff] [review]:
-----------------------------------------------------------------

https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/js/xpconnect/tests/chrome/test_xrayToJS.xul#206 probably needs to be updated, too.

Comment 5

[André Bargull [:anba]]

Comment on attachment 8981391 [details] [diff] [review]
Update test262. r?

Review of attachment 8981391 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/js/src/tests/jstests.list#51 updated to use the new name. Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e44345b44d4e
Update test262. r=anba
https://hg.mozilla.org/integration/mozilla-inbound/rev/516dc753d654
Rename Array.prototype.flatten to Array.prototype.flat. r=anba

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e44345b44d4e
https://hg.mozilla.org/mozilla-central/rev/516dc753d654