Open Bug 1465256 Opened 2 years ago Updated 1 year ago

Remove the requirement to use the `browser‑style` class to apply browser styles when `browser_style` is `true`

Categories

(WebExtensions :: Frontend, defect, P3)

55 Branch
defect

Tracking

(firefox-esr52 unaffected, firefox-esr60 affected, firefox61 affected, firefox62 affected, firefox63 affected)

Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- affected
firefox61 --- affected
firefox62 --- affected
firefox63 --- affected

People

(Reporter: e7358d9c, Unassigned)

References

(Blocks 1 open bug)

Details

Due to bug 418833 and bug 1371951, `<input type="checkbox">` and `<input type="radio">` styles use `input[…] + label::before` selectors as a workaround.

Rather than fixing the underlying issue, the developers fixing bug 1354336 instead choose to introduce the `browser-style` class.

Once bug 1371951 is resolved, it will be possible to remove the `browser-style` style class requirement (i.e. revert d666bbb2097a¹) without introducing regressions.

¹ https://hg.mozilla.org/releases/mozilla-beta/rev/d666bbb2097a
(In reply to ExE Boss from comment #0)
> Rather than fixing the underlying issue, the developers fixing
> bug 1354336 instead chose to introduce the `browser-style` class.

And then, instead of at least limiting the `browser-style` class requirement to just the `input[…] + label::before` selectors, chose to add said requirement to `<button>`, `<select>` and `<textarea>`, which were unaffected by bug 418833 and would’ve been just fine without it.
Priority: -- → P3
Product: Toolkit → WebExtensions
OS: Unspecified → All
Hardware: Unspecified → All
You need to log in before you can comment on or make changes to this bug.