Closed Bug 1465334 Opened 7 years ago Closed 5 years ago

Intermittent browser/components/places/tests/browser/browser_click_bookmarks_on_toolbar.js | Found node on toolbar - null != null - JS frame :: chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_click_bookmarks_on_toolbar.

Categories

(Firefox :: Bookmarks & History, defect, P5)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox85 --- fixed
firefox86 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Gijs)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Bug 1465334 - wait for bookmarks elements to have been created in browser_click_bookmarks_on_toolbar.js, r?mak
47 bytes, text/x-phabricator-request
Details | Review
Filed by: archaeopteryx [at] coole-files.de https://treeherder.mozilla.org/logviewer.html#?job_id=180805561&repo=autoland https://queue.taskcluster.net/v1/task/cfJdZN5iTfyoc08fDeFIKA/runs/0/artifacts/public/logs/live_backing.log 00:57:58 INFO - 211 INFO TEST-START | browser/components/places/tests/browser/browser_click_bookmarks_on_toolbar.js 00:57:59 INFO - TEST-INFO | started process screenshot 00:57:59 INFO - TEST-INFO | screenshot: exit 0 00:57:59 INFO - Buffered messages logged at 00:57:58 00:57:59 INFO - 212 INFO Entering test bound setup 00:57:59 INFO - Buffered messages finished 00:57:59 ERROR - 213 INFO TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_click_bookmarks_on_toolbar.js | Found node on toolbar - null != null - JS frame :: chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_click_bookmarks_on_toolbar.js :: setup :: line 57 00:57:59 INFO - Stack trace: 00:57:59 INFO - chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_click_bookmarks_on_toolbar.js:setup:57 00:57:59 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1083 00:57:59 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1074 00:57:59 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:976 00:57:59 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795

Marco, any ideas what's going on here? :jya noticed these failures when trying to land document channel changes (bug 1632098), but I suspect there's just a race. For instance, https://firefoxci.taskcluster-artifacts.net/cy2BXgp5TBygkxYVdIwKhA/0/public/test_info/mozilla-test-fail-screenshot_rbjiwz.png from https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298343550&repo=autoland&lineNumber=2817 shows that we don't get toolbar nodes based on the guids, already in setup(), but the toolbar nodes are present in the screenshot...

Flags: needinfo?(mak)

(the other 2 failures there show that the bookmarks toolbar hasn't been shown (yet / at all), which is also confusing)

No, this is still a mistery to me.
Bookmarks addition is instant, so they must be in the toolbar root. Updates to the view are also happening before PlacesUtils.bookmarks.insert is resolved. the view may be not visible, the toolbar is disabled by default, but that's the scope of promiseSetToolbarVisibility.

We have another similar test, browser_views_liveupdate.js, that checks toolbar items, and apparently doesn't fail... maybe comparing those can help. though apparently th eonly thing that changes is the time between setup and checks, so maybe promiseSetToolbarVisibility is just not enough?

Flags: needinfo?(mak)

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → INCOMPLETE

This is still happening.

Recent failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318827490&repo=autoland&lineNumber=4174

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

There have been 32 total failures in the last 7 days:
Intermittent failures: https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2020-11-27&endday=2020-12-04&tree=trunk&bug=1465334

Recent log: https://treeherder.mozilla.org/logviewer?job_id=323602081&repo=autoland&lineNumber=2571

Affected platforms:

  • linux1804-64 debug
  • linux1804-64-tsan
  • windows10-64 opt
  • windows10-64-qr opt & debug
  • windows10-64-shippable
    windows10-64-shippable-qr

Marco, could you please assign this to someone who can take a look?

Flags: needinfo?(mak)
Whiteboard: [stockwell needswork:owner]
Assignee: nobody → gijskruitbosch+bugs
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a8b777064be6 wait for bookmarks elements to have been created in browser_click_bookmarks_on_toolbar.js, r=mak

https://hg.mozilla.org/mozilla-central/rev/a8b777064be6

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Flags: needinfo?(mak)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: