1465373 - remove reference to old winxp in manifest file

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

there are two references to winxp (5.1) in this manifest file that we can remove:
https://searchfox.org/mozilla-central/source/dom/canvas/test/webgl-mochitest/mochitest.ini#47

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

and 1 reference in this file:
https://searchfox.org/mozilla-central/source/gfx/tests/mochitest/mochitest.ini#5

Comment 2

[Andreea Pavel [:apavel]]

Attachment: removed osx 10.6 references

Comment 3

[Andreea Pavel [:apavel]]

(In reply to Andreea Pavel [:apavel] from comment #2)
> Created attachment 8982140 [details] [diff] [review]
> removed osx  10.6 references

:jmaher i removed both osx 10 references and win old references

Comment 4

[Andreea Pavel [:apavel]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #1)
> and 1 reference in this file:
> https://searchfox.org/mozilla-central/source/gfx/tests/mochitest/mochitest.
> ini#5

there are no references here, what am i missing?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

oh, good call- it was there in my query, but Eliza cleaned it up while disabling that test on win10 yesterday and I filed the bug while waiting for it to get merged around:
https://hg.mozilla.org/mozilla-central/rev/4e1b975f4897

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982140 [details] [diff] [review]
removed osx  10.6 references

Review of attachment 8982140 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/test/webgl-mochitest/mochitest.ini
@@ +13,4 @@
>    red-green.webmvp9.webm
>  
>  [ensure-exts/test_ANGLE_instanced_arrays.html]
> +fail-if = (os == 'android') || (os == 'mac)'

just like the other feedback, we need to keep the android reference, but remove mac (and win) references in these 3 lines.

Comment 7

[Andreea Pavel [:apavel]]

Attachment: removed osx and win references

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982186 [details] [diff] [review]
removed osx and win references

Review of attachment 8982186 [details] [diff] [review]:
-----------------------------------------------------------------

outside of my comments, the other edits are good!

::: dom/canvas/test/webgl-mochitest/mochitest.ini
@@ +33,4 @@
>  [ensure-exts/test_WEBGL_color_buffer_float.html]
>  fail-if = (os == 'android')
>  [ensure-exts/test_WEBGL_compressed_texture_atc.html]
> +fail-if = (os == 'android') || (os == 'linux')

here we need to keep os == 'win' and os == 'mac' since it originally had no version specific information

@@ +37,2 @@
>  [ensure-exts/test_WEBGL_compressed_texture_es3.html]
> +fail-if = (os == 'android')

same here, keep win/mac

@@ +39,2 @@
>  [ensure-exts/test_WEBGL_compressed_texture_etc1.html]
> +fail-if = (os == 'linux')

and here as well, keep win/mac

@@ +41,2 @@
>  [ensure-exts/test_WEBGL_compressed_texture_pvrtc.html]
> +fail-if = (os == 'android') 

here we need to keep linux/win/mac

Comment 9

[Andreea Pavel [:apavel]]

Attachment: removed osx and win references

I think you gave a review+ by mistake to the previous one so i marked it as obsolete.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982194 [details] [diff] [review]
removed osx and win references

Review of attachment 8982194 [details] [diff] [review]:
-----------------------------------------------------------------

looks good.

there is one other file referenced in comment 1:
https://searchfox.org/mozilla-central/source/gfx/tests/mochitest/mochitest.ini#5

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99285afe81d6
Remove reference to old winxp in manifest file. r=jmaher

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/99285afe81d6