Closed
Bug 1465373
Opened 7 years ago
Closed 7 years ago
remove reference to old winxp in manifest file
Categories
(Core :: Graphics: CanvasWebGL, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: jmaher, Assigned: apavel)
References
Details
Attachments
(1 file, 2 obsolete files)
950 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
there are two references to winxp (5.1) in this manifest file that we can remove:
https://searchfox.org/mozilla-central/source/dom/canvas/test/webgl-mochitest/mochitest.ini#47
Reporter | ||
Comment 1•7 years ago
|
||
and 1 reference in this file:
https://searchfox.org/mozilla-central/source/gfx/tests/mochitest/mochitest.ini#5
Assignee | ||
Comment 2•7 years ago
|
||
Assignee: nobody → apavel
Attachment #8982140 -
Flags: review?(jmaher)
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Andreea Pavel [:apavel] from comment #2)
> Created attachment 8982140 [details] [diff] [review]
> removed osx 10.6 references
:jmaher i removed both osx 10 references and win old references
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #1)
> and 1 reference in this file:
> https://searchfox.org/mozilla-central/source/gfx/tests/mochitest/mochitest.
> ini#5
there are no references here, what am i missing?
Flags: needinfo?(jmaher)
Reporter | ||
Comment 5•7 years ago
|
||
oh, good call- it was there in my query, but Eliza cleaned it up while disabling that test on win10 yesterday and I filed the bug while waiting for it to get merged around:
https://hg.mozilla.org/mozilla-central/rev/4e1b975f4897
Flags: needinfo?(jmaher)
Reporter | ||
Comment 6•7 years ago
|
||
Comment on attachment 8982140 [details] [diff] [review]
removed osx 10.6 references
Review of attachment 8982140 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/canvas/test/webgl-mochitest/mochitest.ini
@@ +13,4 @@
> red-green.webmvp9.webm
>
> [ensure-exts/test_ANGLE_instanced_arrays.html]
> +fail-if = (os == 'android') || (os == 'mac)'
just like the other feedback, we need to keep the android reference, but remove mac (and win) references in these 3 lines.
Attachment #8982140 -
Flags: review?(jmaher) → review-
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8982140 -
Attachment is obsolete: true
Attachment #8982186 -
Flags: review?(jmaher)
Reporter | ||
Comment 8•7 years ago
|
||
Comment on attachment 8982186 [details] [diff] [review]
removed osx and win references
Review of attachment 8982186 [details] [diff] [review]:
-----------------------------------------------------------------
outside of my comments, the other edits are good!
::: dom/canvas/test/webgl-mochitest/mochitest.ini
@@ +33,4 @@
> [ensure-exts/test_WEBGL_color_buffer_float.html]
> fail-if = (os == 'android')
> [ensure-exts/test_WEBGL_compressed_texture_atc.html]
> +fail-if = (os == 'android') || (os == 'linux')
here we need to keep os == 'win' and os == 'mac' since it originally had no version specific information
@@ +37,2 @@
> [ensure-exts/test_WEBGL_compressed_texture_es3.html]
> +fail-if = (os == 'android')
same here, keep win/mac
@@ +39,2 @@
> [ensure-exts/test_WEBGL_compressed_texture_etc1.html]
> +fail-if = (os == 'linux')
and here as well, keep win/mac
@@ +41,2 @@
> [ensure-exts/test_WEBGL_compressed_texture_pvrtc.html]
> +fail-if = (os == 'android')
here we need to keep linux/win/mac
Attachment #8982186 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 9•7 years ago
|
||
I think you gave a review+ by mistake to the previous one so i marked it as obsolete.
Attachment #8982186 -
Attachment is obsolete: true
Attachment #8982194 -
Flags: review?(jmaher)
Reporter | ||
Comment 10•7 years ago
|
||
Comment on attachment 8982194 [details] [diff] [review]
removed osx and win references
Review of attachment 8982194 [details] [diff] [review]:
-----------------------------------------------------------------
looks good.
there is one other file referenced in comment 1:
https://searchfox.org/mozilla-central/source/gfx/tests/mochitest/mochitest.ini#5
Attachment #8982194 -
Flags: review?(jmaher) → review+
Reporter | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 11•7 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99285afe81d6
Remove reference to old winxp in manifest file. r=jmaher
Keywords: checkin-needed
Assignee | ||
Comment 12•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•