1465375 - remove reference to old winxp in manifest file

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P5)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

there are 3 references to winxp (5.1 and 5.2 can be removed) in this file:
https://searchfox.org/mozilla-central/source/netwerk/test/unit/xpcshell.ini#362

Comment 1

[Andreea Pavel [:apavel]]

Attachment: removed old win references

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982158 [details] [diff] [review]
removed old win references

Review of attachment 8982158 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/test/unit/xpcshell.ini
@@ -359,4 @@
>  [test_be_conservative.js]
>  # The local cert service used by this test is not currently shipped on Android
>  # Disabled on XP in bug 1190674 for intermittent failures
> -skip-if = os == "android" || (os == "win" && (os_version == "5.1" || os_version == "5.2"))

I am glad you kept android, but now we skip on win7/10, so we need to remove the entire os == 'win' clause

Comment 3

[Andreea Pavel [:apavel]]

Attachment: removed old win references

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982180 [details] [diff] [review]
removed old win references

Review of attachment 8982180 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/test/unit/xpcshell.ini
@@ +363,5 @@
>  reason = bug 1190674
>  firefox-appdir = browser
>  [test_be_conservative_error_handling.js]
>  # The local cert service used by this test is not currently shipped on Android
>  # Disabled on XP in bug 1190674 for intermittent failures

I missed this earlier, can we remove the comment indicating |# Disabled on XP ...|

there is one for each line you edited.  everything else looks great

Comment 5

[Andreea Pavel [:apavel]]

Attachment: removed coments

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982187 [details] [diff] [review]
removed coments

Review of attachment 8982187 [details] [diff] [review]:
-----------------------------------------------------------------

one small detail remaining

::: netwerk/test/unit/xpcshell.ini
@@ +358,5 @@
>  [test_websocket_offline.js]
>  [test_be_conservative.js]
>  # The local cert service used by this test is not currently shipped on Android
> +skip-if = os == "android"
> +	reason = bug 1190674

somehow 'reason' got indented.  that shouldn't be the case.  In fact, we should remove reason since that bug was for winXP.  Sorry for missing that earlier- I would have missed it now if it wasn't indented

Comment 7

[Andreea Pavel [:apavel]]

Attachment: removed references and coments

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982195 [details] [diff] [review]
removed references and coments

Review of attachment 8982195 [details] [diff] [review]:
-----------------------------------------------------------------

right on

Comment 9

[Andreea Pavel [:apavel]]

Attachment: patch with all modifications

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982215 [details] [diff] [review]
patch with all modifications

Review of attachment 8982215 [details] [diff] [review]:
-----------------------------------------------------------------

very cool!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please fix your hg configuration to generate patches that include your name & email.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddcbbad1f728
Remove reference to old winxp in manifest file. r=jmaher

Comment 13

[Andreea Pavel [:apavel]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #11)
> Please fix your hg configuration to generate patches that include your name
> & email.

will do.

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ddcbbad1f728