remove reference to old winxp in manifest file

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P5
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: jmaher, Assigned: apavel)

Tracking

54 Branch
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment, 4 obsolete attachments)

there are 3 references to winxp (5.1 and 5.2 can be removed) in this file:
https://searchfox.org/mozilla-central/source/netwerk/test/unit/xpcshell.ini#362
Priority: -- → P5
Whiteboard: [necko-triaged]
Posted patch removed old win references (obsolete) — Splinter Review
Assignee: nobody → apavel
Attachment #8982158 - Flags: review?(jmaher)
Comment on attachment 8982158 [details] [diff] [review]
removed old win references

Review of attachment 8982158 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/test/unit/xpcshell.ini
@@ -359,4 @@
>  [test_be_conservative.js]
>  # The local cert service used by this test is not currently shipped on Android
>  # Disabled on XP in bug 1190674 for intermittent failures
> -skip-if = os == "android" || (os == "win" && (os_version == "5.1" || os_version == "5.2"))

I am glad you kept android, but now we skip on win7/10, so we need to remove the entire os == 'win' clause
Attachment #8982158 - Flags: review?(jmaher) → review-
Posted patch removed old win references (obsolete) — Splinter Review
Attachment #8982158 - Attachment is obsolete: true
Attachment #8982180 - Flags: review?(jmaher)
Comment on attachment 8982180 [details] [diff] [review]
removed old win references

Review of attachment 8982180 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/test/unit/xpcshell.ini
@@ +363,5 @@
>  reason = bug 1190674
>  firefox-appdir = browser
>  [test_be_conservative_error_handling.js]
>  # The local cert service used by this test is not currently shipped on Android
>  # Disabled on XP in bug 1190674 for intermittent failures

I missed this earlier, can we remove the comment indicating |# Disabled on XP ...|

there is one for each line you edited.  everything else looks great
Attachment #8982180 - Flags: review?(jmaher) → review-
Posted patch removed coments (obsolete) — Splinter Review
Attachment #8982180 - Attachment is obsolete: true
Attachment #8982187 - Flags: review?(jmaher)
Comment on attachment 8982187 [details] [diff] [review]
removed coments

Review of attachment 8982187 [details] [diff] [review]:
-----------------------------------------------------------------

one small detail remaining

::: netwerk/test/unit/xpcshell.ini
@@ +358,5 @@
>  [test_websocket_offline.js]
>  [test_be_conservative.js]
>  # The local cert service used by this test is not currently shipped on Android
> +skip-if = os == "android"
> +	reason = bug 1190674

somehow 'reason' got indented.  that shouldn't be the case.  In fact, we should remove reason since that bug was for winXP.  Sorry for missing that earlier- I would have missed it now if it wasn't indented
Attachment #8982187 - Flags: review?(jmaher) → review-
Attachment #8982187 - Attachment is obsolete: true
Attachment #8982195 - Flags: review?(jmaher)
Comment on attachment 8982195 [details] [diff] [review]
removed references and coments

Review of attachment 8982195 [details] [diff] [review]:
-----------------------------------------------------------------

right on
Attachment #8982195 - Flags: review?(jmaher) → review+
Attachment #8982195 - Attachment is obsolete: true
Attachment #8982215 - Flags: review?(jmaher)
Comment on attachment 8982215 [details] [diff] [review]
patch with all modifications

Review of attachment 8982215 [details] [diff] [review]:
-----------------------------------------------------------------

very cool!
Attachment #8982215 - Flags: review?(jmaher) → review+
Keywords: checkin-needed
Please fix your hg configuration to generate patches that include your name & email.
Flags: needinfo?(apavel)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddcbbad1f728
Remove reference to old winxp in manifest file. r=jmaher
Keywords: checkin-needed
(In reply to Ryan VanderMeulen [:RyanVM] from comment #11)
> Please fix your hg configuration to generate patches that include your name
> & email.

will do.
Flags: needinfo?(apavel)
https://hg.mozilla.org/mozilla-central/rev/ddcbbad1f728
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.