Closed Bug 1465377 Opened 8 years ago Closed 8 years ago

remove reference to old winxp/win8 in manifest file

Categories

(Core :: Graphics: Canvas2D, enhancement)

Product:
Core
Component:
Graphics: Canvas2D
Version:
54 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: jmaher, Assigned: ebalazs_)

References

Details

Attachments

(2 files, 2 obsolete files)

Removed old win reference
1.06 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
Removed old win reference
1.14 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
Attached patch Removed old win reference (obsolete) — — Splinter Review
Attachment #8982171 - Flags: review?(jmaher)
Assignee: nobody → ebalazs
Attached patch Removed old win reference (obsolete) — — Splinter Review
Attachment #8982173 - Flags: review?(jmaher)
Comment on attachment 8982171 [details] [diff] [review] Removed old win reference Review of attachment 8982171 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/web-platform/meta/2dcontext/drawing-paths-to-the-canvas/drawFocusIfNeeded_001.html.ini @@ -4,5 @@ > [drawFocusIfNeeded draws a focus ring.] > expected: > - if not debug and (os == "win") and (version == "6.2.9200") and (processor == "x86_64") and (bits == 64): FAIL > - if not debug and (os == "win") and (version == "5.1.2600") and (processor == "x86") and (bits == 32): FAIL > - if not debug and (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): FAIL we need to keep the 6.1.7601 reference, but not the others. In this case we say this fails on windows 10 as well.
Attachment #8982171 - Flags: review?(jmaher) → review-
Comment on attachment 8982173 [details] [diff] [review] Removed old win reference Review of attachment 8982173 [details] [diff] [review]: ----------------------------------------------------------------- same as the last one, we need to keep reference to windows 7 (6.1.7601)
Attachment #8982173 - Flags: review?(jmaher) → review-
Attachment #8982171 - Attachment is obsolete: true
Attachment #8982173 - Attachment is obsolete: true
Attachment #8982179 - Flags: review?(jmaher)
Attachment #8982182 - Flags: review?(jmaher)
Comment on attachment 8982179 [details] [diff] [review] Removed old win reference Review of attachment 8982179 [details] [diff] [review]: ----------------------------------------------------------------- great!
Attachment #8982179 - Flags: review?(jmaher) → review+
Comment on attachment 8982182 [details] [diff] [review] Removed old win reference Review of attachment 8982182 [details] [diff] [review]: ----------------------------------------------------------------- great!
Attachment #8982182 - Flags: review?(jmaher) → review+
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3765db5a229e remove reference to old win in manifest file. r=jmaher
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e351641c60f2 remove reference to old win in manifest file. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/3765db5a229e https://hg.mozilla.org/mozilla-central/rev/e351641c60f2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: