Closed
Bug 1465377
Opened 6 years ago
Closed 6 years ago
remove reference to old winxp/win8 in manifest file
Categories
(Core :: Graphics: Canvas2D, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: jmaher, Assigned: ebalazs_)
References
Details
Attachments
(2 files, 2 obsolete files)
|
1.06 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
|
1.14 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
we can remove references to 5.1 and 6.2 from these manifests: https://searchfox.org/mozilla-central/source/testing/web-platform/meta/2dcontext/drawing-paths-to-the-canvas/drawFocusIfNeeded_001.html.ini#7 https://searchfox.org/mozilla-central/source/testing/web-platform/meta/2dcontext/drawing-paths-to-the-canvas/drawFocusIfNeeded_005.html.ini#7 https://searchfox.org/mozilla-central/source/testing/web-platform/meta/2dcontext/drawing-paths-to-the-canvas/drawFocusIfNeeded_005.html.ini#7
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8982171 -
Flags: review?(jmaher)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → ebalazs
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8982173 -
Flags: review?(jmaher)
|
Reporter | |
Comment 3•6 years ago
|
||
Comment on attachment 8982171 [details] [diff] [review] Removed old win reference Review of attachment 8982171 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/web-platform/meta/2dcontext/drawing-paths-to-the-canvas/drawFocusIfNeeded_001.html.ini @@ -4,5 @@ > [drawFocusIfNeeded draws a focus ring.] > expected: > - if not debug and (os == "win") and (version == "6.2.9200") and (processor == "x86_64") and (bits == 64): FAIL > - if not debug and (os == "win") and (version == "5.1.2600") and (processor == "x86") and (bits == 32): FAIL > - if not debug and (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): FAIL we need to keep the 6.1.7601 reference, but not the others. In this case we say this fails on windows 10 as well.
Attachment #8982171 -
Flags: review?(jmaher) → review-
|
|
Reporter | |
Comment 4•6 years ago
|
||
Comment on attachment 8982173 [details] [diff] [review] Removed old win reference Review of attachment 8982173 [details] [diff] [review]: ----------------------------------------------------------------- same as the last one, we need to keep reference to windows 7 (6.1.7601)
Attachment #8982173 -
Flags: review?(jmaher) → review-
|
|
Assignee | |
Comment 5•6 years ago
|
||
Attachment #8982171 -
Attachment is obsolete: true
Attachment #8982173 -
Attachment is obsolete: true
Attachment #8982179 -
Flags: review?(jmaher)
|
|
Assignee | |
Comment 6•6 years ago
|
||
Attachment #8982182 -
Flags: review?(jmaher)
|
|
Reporter | |
Comment 7•6 years ago
|
||
Comment on attachment 8982179 [details] [diff] [review] Removed old win reference Review of attachment 8982179 [details] [diff] [review]: ----------------------------------------------------------------- great!
Attachment #8982179 -
Flags: review?(jmaher) → review+
|
|
Reporter | |
Comment 8•6 years ago
|
||
Comment on attachment 8982182 [details] [diff] [review] Removed old win reference Review of attachment 8982182 [details] [diff] [review]: ----------------------------------------------------------------- great!
Attachment #8982182 -
Flags: review?(jmaher) → review+
|
|
Reporter | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3765db5a229e remove reference to old win in manifest file. r=jmaher
Keywords: checkin-needed
|
||
Comment 10•6 years ago
|
||
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e351641c60f2 remove reference to old win in manifest file. r=jmaher
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3765db5a229e https://hg.mozilla.org/mozilla-central/rev/e351641c60f2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•