Add ability to optionally load XUL reftests in a privileged context
Categories
(Testing :: Reftest, enhancement)
Tracking
(firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: Paolo, Assigned: bgrins)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(3 files, 4 obsolete files)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Reporter | ||
Comment 4•7 years ago
|
||
Reporter | ||
Comment 5•7 years ago
|
||
Reporter | ||
Comment 6•7 years ago
|
||
Comment 7•7 years ago
|
||
Comment 8•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Comment 10•7 years ago
|
||
Assignee | ||
Comment 12•7 years ago
|
||
Reporter | ||
Comment 13•7 years ago
|
||
Comment 14•7 years ago
|
||
Reporter | ||
Comment 15•7 years ago
|
||
Assignee | ||
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
![]() |
||
Comment 19•7 years ago
|
||
Assignee | ||
Comment 20•7 years ago
|
||
Reporter | ||
Comment 21•7 years ago
|
||
Comment 22•7 years ago
|
||
Assignee | ||
Comment 23•7 years ago
|
||
Assignee | ||
Comment 24•7 years ago
|
||
Assignee | ||
Comment 25•7 years ago
|
||
Assignee | ||
Comment 26•7 years ago
|
||
Assignee | ||
Comment 27•7 years ago
|
||
Assignee | ||
Comment 28•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Comment 29•7 years ago
|
||
I am worried that if we don't address this first, many of the tests will be in a false positive state as we migrate more bindings to custom elements.
In bug 1518932, I am forced to manually generate "anonymous nodes" in toolkit/themes/osx/reftests/nostretch.xul and its reference in order to make the test pass.
Assignee | ||
Comment 30•7 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #29)
I am worried that if we don't address this first, many of the tests will be in a false positive state as we migrate more bindings to custom elements.
In bug 1518932, I am forced to manually generate "anonymous nodes" in toolkit/themes/osx/reftests/nostretch.xul and its reference in order to make the test pass.
Yeah, this is going to block a lot of the remaining bindings and we should take it ASAP. There's a bit of discussion going on in the phab review about how to make this happen. Should we make this block bug 1518932 so you don't need to manually generate the nodes?
Comment 31•7 years ago
•
|
||
(In reply to Brian Grinstead [:bgrins] from comment #30)
Yeah, this is going to block a lot of the remaining bindings and we should take it ASAP. There's a bit of discussion going on in the phab review about how to make this happen. Should we make this block bug 1518932 so you don't need to manually generate the nodes?
It's really depends on the timeline of this bug. I am hoping to land bug 1518932 this month so I am going for the //XXX generate "anonymous" nodes manually
route for now.
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 32•6 years ago
|
||
Assignee | ||
Comment 33•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 34•6 years ago
|
||
We are running certain xul reftests in the content process registered in chrome://reftest,
and it's OK for them to call this function (which is triggered at end of XUL doc loading).
Comment 35•6 years ago
|
||
Comment 36•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ec6c7dcf2f31
https://hg.mozilla.org/mozilla-central/rev/ed020882a318
https://hg.mozilla.org/mozilla-central/rev/d7779ef1fa2f
Assignee | ||
Comment 37•6 years ago
|
||
Updated documentation at https://developer.mozilla.org/en-US/docs/Mozilla/Creating_reftest-based_unit_tests#Reftests_and_elevated_privileges to reflect this as an option.
Description
•