1465497 - Title bar and drag space text in customize mode with dark theme can't be read on hovering

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Clément Lefèvre]

Attachment: Screencast from 30-05-2018 16:59:42.webm

See the joined video, when user is hovering title bar or drag space text in the customize mode, the text is using same color as background, and therefore become impossible to read.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

What platform/OS are you using? Can you share more of your build information? I'm unable to reproduce this on 62.0a1 (2018-05-30) (64-bit) Windows 10 with the Dark theme enabled.

Comment 2

[Clément Lefèvre]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> What platform/OS are you using? Can you share more of your build
> information? I'm unable to reproduce this on 62.0a1 (2018-05-30) (64-bit)
> Windows 10 with the Dark theme enabled.

Video was recorded on Archlinux with latest Gnome/GTK and using the latest nightly.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Thanks, can you run mozregression[1] to see if this is a recent regression? If we can narrow down when this started happening it will be much easier to fix. 

[1] http://mozilla.github.io/mozregression/

Comment 4

[Clément Lefèvre]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> Thanks, can you run mozregression[1] to see if this is a recent regression?
> If we can narrow down when this started happening it will be much easier to
> fix. 
> 
> [1] http://mozilla.github.io/mozregression/

Arrived on https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9f8b177edf71215098643f5a705fe8730734c346&tochange=63224d6e543cc3399f419dd4ac500873db02b021 which probably is the commit that introduced those options: I was able to reproduce it on every build with the options existing.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Thanks, I won't mark this as a regression since this was basically broken on your setup since the feature was introduced. I don't think this change actually caused the problem, it may have just made the problem visible.

Comment 6

[Dão Gottwald [:dao]]

It looks like something changed on the Gtk side with regards to how checkboxes are rendered. They used to get a solid background on hover (which always felt weird) and so we also set a text color for the hover state.

Comment 7

[Dão Gottwald [:dao]]

Attachment: Bug 1465497 - Stop setting a color on hovered checkboxes and radio buttons.

Gtk checkboxes and radio buttons used to render a solid background on hover and so we also set a text color for that state. Apparently we're not getting that background anymore.

Review commit: https://reviewboard.mozilla.org/r/248562/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248562/

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8982581 [details]
Bug 1465497 - Stop setting a color on hovered checkboxes and radio buttons.

https://reviewboard.mozilla.org/r/248562/#review254780

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/330f40fac3e8
Stop setting a color on hovered checkboxes and radio buttons. r=jaws

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/330f40fac3e8

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Hi Clément, this fix should be available in the latest Nightly builds. Can you confirm that this is working better for you now? Thanks!

Comment 12

[Clément Lefèvre]

Yes it's fixed for me.

However, there's two things to take care about too:

- I'm using latest Gnome/GTK, and :dao seemed to say this could have been caused by changes on their side. For that reason, I think it would be nice to check it on older Gnome/GTKs. I don't have some at hand, so it would require other people to check this out.

- When clicking the checkboxes, it now presents a text-decoration all around the text, is that normal?

Comment 13

[Dão Gottwald [:dao]]

(In reply to Clément Lefèvre from comment #12)
> Yes it's fixed for me.
> 
> However, there's two things to take care about too:
> 
> - I'm using latest Gnome/GTK, and :dao seemed to say this could have been
> caused by changes on their side. For that reason, I think it would be nice
> to check it on older Gnome/GTKs. I don't have some at hand, so it would
> require other people to check this out.

I think we can just let this ride 63 train to catch such cases.

> - When clicking the checkboxes, it now presents a text-decoration all around
> the text, is that normal?

The focus ring? Yes, that's normal.

Comment 14

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #13)
> (In reply to Clément Lefèvre from comment #12)
> > Yes it's fixed for me.
> > 
> > However, there's two things to take care about too:
> > 
> > - I'm using latest Gnome/GTK, and :dao seemed to say this could have been
> > caused by changes on their side. For that reason, I think it would be nice
> > to check it on older Gnome/GTKs. I don't have some at hand, so it would
> > require other people to check this out.
> 
> I think we can just let this ride 63 train to catch such cases.

Oops, I meant 62. I.e. no uplift, just let this bake in Nightly and then Beta.