Closed Bug 1465548 Opened 6 years ago Closed 6 years ago

Pocket about:preferences "Learn more" is in the wrong place

Categories

(Firefox :: New Tab Page, defect, P2)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 63
Iteration:
63.1 - July 9
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- wontfix
firefox63 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

link placement
68.38 KB, image/png
Details
Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4231
52 bytes, text/x-github-pull-request
Details | Review
Attached image link placement —
Bug 1400536 exposed an issue with section preferences that show a link as well as a drop down -- so Pocket. uiwanted: Part of the issue is all these items (description, link, rows drop down) appearing on the same line leading to wrapping issues with long (translated) text. Could the drop down move up a line to the name of the section?
Iteration: --- → 62.4 - Jul 2
status-firefox61: --- → unaffected
status-firefox62: --- → affected
Priority: -- → P3
Iteration: 62.4 - Jul 2 → 63.1 - July 9
Iteration: 63.1 - July 9 → ---
uifeedback: Put the "Learn more" link on the in line after "Recommended by Pocket" Wontfix for 62 but we'll want this in for 63.
Iteration: --- → 63.2 - July 23
Keywords: uiwanted
Priority: P3 → P2
Looks like we need the hbox to contain the checkbox header.
Assignee: nobody → edilee
Iteration: 63.2 - July 23 → 63.1 - July 9
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/fcd3373e4b24bad34e22789ccb5320dbb3382707 fix(preferences): Update sponsored box to contain the main checkbox instead of description (#4231) Fix Bug 1465548 - Pocket about:preferences "Learn more" is in the wrong place
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1473744
I have verified that the issue is no longer reproducible on the latest Nightly build (63.0a1, Build ID 20180708220048) on Windows 10 x64, Mac 10.13.6 and Arch Linux x64.
Status: RESOLVED → VERIFIED
status-firefox63: affected → verified
https://hg.mozilla.org/mozilla-central/rev/c8abaff6bcae
Target Milestone: --- → Firefox 63
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: