report channel failure back to child correctly when parent-side SW interception occurs

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P2
normal
RESOLVED FIXED
11 months ago
3 months ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

(Blocks 1 bug)

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
There is a silly bug in HttpChannelParent when parent interception is enabled.  Currently we only get the parent-side channel status for nsHttpChannel, but not InterceptedHttpChannel:

https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/netwerk/protocol/http/HttpChannelParent.cpp#1427

This needs to apply to both types of channels in order to reflect failed loads back to the child process correctly.
(Assignee)

Comment 1

11 months ago
Honza, this is pretty straightforward.  In bug 1391693 I made HttpChannelParent support underlying channels that extend HttpBaseChannel instead of requiring an exact nsHttpChannel.  This allows it to operate on InterceptedHttpChannel objects.  I made a mistake, though, and made the code only get the underlying channel status for nsHttpChannels.

This patch just moves the channel status getter out of the conditional block so it applies whenever we have an HttpBaseChannel.  This is necessary for the child process to see failures from an InterceptedHttpChannel.
Attachment #8982005 - Flags: review?(honzab.moz)
(Assignee)

Updated

11 months ago
Blocks: 1391693

Updated

11 months ago
Priority: -- → P2
Attachment #8982005 - Flags: review?(honzab.moz) → review+

Comment 2

11 months ago
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f4eeef07a85
Make HttpChannelParent get the channel status when its underlying channel is an InterceptedHttpChannel. r=mayhemer

Comment 3

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7f4eeef07a85
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.