Open Bug 1462460 Opened 2 years ago Updated 10 months ago

[meta] green up service worker tests with e10s pref flipped

Categories

(Core :: DOM: Service Workers, enhancement, P2)

enhancement

Tracking

()

People

(Reporter: bkelly, Unassigned)

References

(Depends on 2 open bugs, Blocks 1 open bug)

Details

(Keywords: meta, Whiteboard: SW-MUST)

Attachments

(1 obsolete file)

Now that we are getting closer to be able to turn on the e10s pref we can start running tests and trying to get them green.  I'll hang various fixes off of this.

The starting point here is with patches from bug 1459209 and bug 1462069.
Depends on: 1462464
Depends on: 1462466
Depends on: 1462467
Depends on: 1462772
Priority: -- → P3
Depends on: 1465580
Depends on: 1441932
Depends on: 1465587
Depends on: 1468209
Depends on: 1468213
Depends on: 1468248
Depends on: 1468340
Depends on: 1468828
Depends on: 1468853
Depends on: 1469024
Depends on: 1469036
Depends on: 1469048
Whiteboard: SW-MUST
Depends on: 1469882
Depends on: 1469941
Depends on: 1469988
Depends on: 1470234
Depends on: 1470254
My current work-in-progress patch queue has green WPT and mostly green mochitests.  Main failing mochitests are things like devtools, browser chrome tests, etc.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e8e6d046a34f85cd55039618edfa3a3e6325cc1
Depends on: 1470286
Valentin, as I discuss in comment 0 I want to preserve channel creation and async open time across internal redirects.  Our current practice of resetting the start of the channel time on every internal redirect produces overly optimistic numbers since it ignores real network stack execution time.

Also, I need this in order to properly track time across the additional internal redirects used by the new service worker parent intercept.  There is a test that verifies that the service worker intercept time is accurately reported.  Currently its missed in this mode without a change like this.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2712e428fd77d9772075fd7bbd2e0ea5d5ea4f7f
Attachment #8986904 - Flags: review?(valentin.gosu)
No longer depends on: 1462467
Attachment #8986904 - Flags: review?(valentin.gosu) → review+
Thanks for the review.  I accidently put this patch and review on the wrong bug.  I'll move it to the correct bug before landing.
Comment on attachment 8986904 [details] [diff] [review]
Propagate channel creation and async open time across internal redirects. r=valentin

Moved to bug 1470286.
Attachment #8986904 - Attachment is obsolete: true
No longer depends on: 1462772
Depends on: 1472303
Depends on: 1472307
Assignee: ben → nobody
Status: ASSIGNED → NEW
Priority: P3 → P2
You need to log in before you can comment on or make changes to this bug.