1465735 - Add Mac code coverage build definition

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Description

[Marco Castelluccio [:marco]]

Even if we're not running it on every mozilla-central push, we should at least have support for it.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982162 [details] [diff] [review]
Patch

Review of attachment 8982162 [details] [diff] [review]:
-----------------------------------------------------------------

2 small nits here

::: browser/config/mozconfigs/macosx64/code-coverage-opt
@@ +1,1 @@
> +. "$topsrcdir/browser/config/mozconfigs/macosx64/code-coverage"

why do we have opt and debug?  for win/linux it is debug only

::: taskcluster/ci/build/macosx.yml
@@ +288,5 @@
> +        symbol: B
> +        tier: 1
> +    worker-type: aws-provisioner-v1/gecko-{level}-b-macosx64
> +    worker:
> +        max-run-time: 36000

10 hours?  that seems too high, does this finish in 2 hours?

Comment 3

[Marco Castelluccio [:marco]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #2)
> Comment on attachment 8982162 [details] [diff] [review]
> Patch
> 
> Review of attachment 8982162 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> 2 small nits here
> 
> ::: browser/config/mozconfigs/macosx64/code-coverage-opt
> @@ +1,1 @@
> > +. "$topsrcdir/browser/config/mozconfigs/macosx64/code-coverage"
> 
> why do we have opt and debug?  for win/linux it is debug only

We've added opt on Linux lately for fuzzing, not sure if they will ever need opt on Mac though.

> 
> ::: taskcluster/ci/build/macosx.yml
> @@ +288,5 @@
> > +        symbol: B
> > +        tier: 1
> > +    worker-type: aws-provisioner-v1/gecko-{level}-b-macosx64
> > +    worker:
> > +        max-run-time: 36000
> 
> 10 hours?  that seems too high, does this finish in 2 hours?

I hadn't noticed, I just copied it from the normal mac debug build. It seems like all builds in macosx.yml have 36000 as max-run-time. Maybe a mistake that got copied and pasted over and over?
https://bugzilla.mozilla.org/show_bug.cgi?id=1286075#c212

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

I don't see osx builds on m-c taking >45 minutes; what do try pushes show for osx ccov builds?  I would like to keep this within 20% of normal build times if possible.

Comment 5

[Marco Castelluccio [:marco]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #4)
> I don't see osx builds on m-c taking >45 minutes; what do try pushes show
> for osx ccov builds?  I would like to keep this within 20% of normal build
> times if possible.

In my latest few try pushes, they took between 19 and 58 minutes. So maybe we can set a limit of 5400 seconds?

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

5400 is great

Comment 7

[Marco Castelluccio [:marco]]

Attachment: Patch

I've reduced the max run time to 5400 and removed the code-coverage-opt mozconfig.

Comment 8

[Marco Castelluccio [:marco]]

Attachment: Only run on try

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8982233 [details] [diff] [review]
Patch

Review of attachment 8982233 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/803d83c6abc3
Add Mac code coverage build definition. r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c22a7591cb9
Allow Mac build to only run on try. r=jmaher

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/803d83c6abc3
https://hg.mozilla.org/mozilla-central/rev/7c22a7591cb9