1466120 - UI cleanups

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement)

Description

[Mark Côté [:mcote]]

There are a number of rough edges in Lando's UI right now which we should clean up soon.  Glob's list follows.  I think some of these have already been filed; I'll look for them after and mark them as blockers.  We can also file more individual bugs as necessary.

* fix "this revision is already queued for landing with the same diff" error (currently in progress)
* add clear itemised links to
 * the bug
 * the phabricator diff
 * the revision on hg (if landed)
* provide a clear indication if a diff has already landed
 * currently it's presented as a warning
 * icons and colours would help
* provide a clear indication why the land button is disabled
* make it clear what the checkbox next to warnings enables the land button
* linkify text in warnings (bugs, diffs, revision shas)
* improve the toggling of the full commit description
 * <button> looks out of place (perhaps "show more" and "show less" links)
 * alternatively a triangle spinner will make it easier to toggle, as the control won't move when the visibility changes
 * alternatively always show the full commit message, and move the land button above it so it's always in the same approximate location

Comment 1

[Mark Côté [:mcote]]

Also related is cleanups to the the UI for closed revisions.  There is possibly some overlap with some of the above.

Comment 2

[Mark Côté [:mcote]]

Actually seems that no other items above have been filed yet.

Comment 3

[:glob ✱]

> * fix "this revision is already queued for landing with the same diff" error

this is bug 1457534

Comment 4

[Israel Madueme [:imadueme]]

Done, plans for Bug 1460037 to be fixed at another time.