1466504 - Should we remove the option to upload screenshots to imgur?

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P5)

Description

[Soledad Penades [:sole] [:spenades]]

Imgur uploads were implemented mostly in Bug 992386, and enable users to upload screenshots to imgur by using the --imgur option when using the screenshot command in GCLI.

While moving the screenshots functionality from the GCLI to the console in Bug 1464461, we wondered if we should remove this option.

I did some web searches to try and assess how popular this functionality is. In short: not much.

First I found someone concerned about imgur values on their browser prefs after having used imgur (unrelated to DevTools), and even having emptied their cookies etc:
https://groups.google.com/forum/#!topic/mozilla.support.firefox/ppHI9Cs8YM0

So this is potentially concerning for users due to the fact that there's an "id" stored on the prefs. While this ID is unique to the whole Firefox user base, and should not be possible to be used to identify specific users, it can identify that they used Firefox. I have found concerns about the usage of an ID and the existence of imgur prefs in other pages. E.g. in the comments here https://www.ghacks.net/2016/03/29/mozilla-system-add-ons-controls/

I did find a couple mentions to using the actual screenshot feature:

* http://savas.co.uk/2017/firefox-developer-toolbar-taking-screenshots-and-uploading-to-imgur-in-seconds/
* https://icoderaw.com/articles/firefox-quantum-review-browser-built-with-speed-tools-modern-web/

But overall, not a lot of mentions.

We have been discussing the possibility of exposing the screenshot functionality to WebExtensions to DevTools, so other addons could take screenshots and upload to imgur and/or any other image sharing website. Perhaps that would be a better solution than specifically tying DevTools to this one single provider.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Now that we have an in-product Firefox Screenshots feature, perhaps we can change DevTools screenshot features to allow uploading there if desired and remove the imgur option?

Comment 2

[Soledad Penades [:sole] [:spenades]]

Perhaps! But to keep this scoped to the actual work, the question has been answered as the imgur support was removed when migrating the screenshot command to the console in Bug 1464461, as we would have to rework the imgur functionality to make it work.

So I'm going to close this bug and file a new one to potentially upload to Firefox Screenshots which doesn't block the GCLI removal work.

Comment 3

[Soledad Penades [:sole] [:spenades]]

New bug for Firefox Screenshots in the console: https://bugzilla.mozilla.org/show_bug.cgi?id=1473853