Closed
Bug 1447491
Opened 6 years ago
Closed 6 years ago
Stop using gcli commands for doing node screenshots in the inspector
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P2)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1483173
People
(Reporter: ochameau, Assigned: yulia)
References
Details
Attachments
(1 obsolete file)
Inspector has a context menu entry for screenshoting a DOM element. It currently involves a GCLI command and should instead use an actor method to do that: https://searchfox.org/mozilla-central/source/devtools/client/inspector/inspector.js#2107-2121 This is to be coordinated with bug 1447490 which also aims to remove another usage of screenshot command. The actual screenshot code is here: https://searchfox.org/mozilla-central/source/devtools/shared/gcli/commands/screenshot.js#80
Comment 1•6 years ago
|
||
I made this depend on bug 1282462 which aims at preserving the --fullpage option, which is very useful. I also think we should consider preserving the --dpi option somehow.
Priority: -- → P2
Updated•6 years ago
|
Assignee: nobody → ystartsev
Updated•6 years ago
|
Product: Firefox → DevTools
Assignee | ||
Comment 2•6 years ago
|
||
Refactor the inspector code to use the same path as the webconsole, in order to remove GCLI
Assignee | ||
Comment 3•6 years ago
|
||
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ea0d87f3b66d4fef0734ccb68cff96c2d8cad26
Assignee | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Updated•6 years ago
|
Attachment #8998169 -
Attachment is obsolete: true
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•