1447491 - Stop using gcli commands for doing node screenshots in the inspector

Status: RESOLVED DUPLICATE of bug 1483173

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P2)

Description

[Alexandre Poirot [:ochameau] [PTO back Jan 5th]]

Inspector has a context menu entry for screenshoting a DOM element.
It currently involves a GCLI command and should instead use an actor method to do that:
https://searchfox.org/mozilla-central/source/devtools/client/inspector/inspector.js#2107-2121

This is to be coordinated with bug 1447490 which also aims to remove another usage of screenshot command.

The actual screenshot code is here:
https://searchfox.org/mozilla-central/source/devtools/shared/gcli/commands/screenshot.js#80

Comment 1

[Patrick Brosset <:pbro>]

I made this depend on bug 1282462 which aims at preserving the --fullpage option, which is very useful. I also think we should consider preserving the --dpi option somehow.

Comment 2

[Yulia Startsev [:yulia] OOO until July 2026]

Attachment: use webconsole screenshot for inspector screenshots; r=jdescottes

Refactor the inspector code to use the same path as the webconsole, in order to remove GCLI

Comment 3

[Yulia Startsev [:yulia] OOO until July 2026]

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ea0d87f3b66d4fef0734ccb68cff96c2d8cad26