Closed Bug 1447491 Opened 6 years ago Closed 6 years ago

Stop using gcli commands for doing node screenshots in the inspector

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1483173

People

(Reporter: ochameau, Assigned: yulia)

References

Details

Attachments

(1 obsolete file)

Inspector has a context menu entry for screenshoting a DOM element.
It currently involves a GCLI command and should instead use an actor method to do that:
https://searchfox.org/mozilla-central/source/devtools/client/inspector/inspector.js#2107-2121

This is to be coordinated with bug 1447490 which also aims to remove another usage of screenshot command.

The actual screenshot code is here:
https://searchfox.org/mozilla-central/source/devtools/shared/gcli/commands/screenshot.js#80
Depends on: 1282462
I made this depend on bug 1282462 which aims at preserving the --fullpage option, which is very useful. I also think we should consider preserving the --dpi option somehow.
Assignee: nobody → ystartsev
Product: Firefox → DevTools
No longer depends on: 1463129
No longer depends on: 1463131
Refactor the inspector code to use the same path as the webconsole, in order to remove GCLI
Depends on: 1483173
No longer depends on: 1473895
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Attachment #8998169 - Attachment is obsolete: true
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.