1466511 - Shield icon for tracking protection not displayed in private browsing

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Stefan Deiac]

Attachment: ssover.png

Environment:
Devices: Motorola Nexus 6(Android 7.1.1), Google Pixel(Android 8.1.0);
Build: Nightly 62.0a1 (2018-05-31);
Prerequisites: Tracking protection is enabled in private browsing;

Steps to reproduce:
1. Open private browsing and go to https://espn.go.com.
2. Pay attention to security level indicator of the site.

Expected results:
A shield icon is displayed with the message:"Tracking Protection Enabled. Attempts to track your online behavior have been blocked."

Actual results:
A grey globe it's displayed.

Comment 1

[Stefan Deiac]

Regression range:

Last good build: 7561cf8f (2018-05-29 22:16:31.404000)
First bad build: 951c7d8e (2018-05-29 22:18:04.432000)
Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7561cf8f0e931a81412850f2481d9a41877f33ce&tochange=951c7d8ee07944d45f67c9aece69f34a7b7ef772

Comment 2

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1466511-1.0-Default-to-block-all-tracker-categor.patch

Currently, we default to CATEGORY_NONE when instantiating GeckoRuntimeSettings, which breaks Fennec support.

We should default to block all tracker types, I think it's also a reasonable default for GeckoView.

Comment 3

[Eugen Sawin [:esawin]]

Comment on attachment 8985079 [details] [diff] [review]
0001-Bug-1466511-1.0-Default-to-block-all-tracker-categor.patch

Redirecting review due to PTO.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f444f8afb355
[1.0] Default to block all tracker categories. r=jchen

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f444f8afb355

Comment 6

[Stefan Deiac]

Verified as fixed on latest Nightly buid(62.0a1 2018-06-20). 
Devices: Samsung Galaxy Tab S3 (Android 7.0.0) and Motorola Nexus 6 (Android 7.1.1).
The shield icon is displayed without any issue.