1478114 - Don't block content trackers by default

Status: VERIFIED FIXED

(GeckoView :: General, defect, P1)

Description

[Eugen Sawin [:esawin]]

Currently, we default to block all types of trackers in GeckoView, including CATEGORY_CONTENT, which can be too restrictive and break major site features.

We should change the default to exclude CATEGORY_CONTENT to provide a better default experience and avoid more restrictive blocking on Fennec compared to desktop.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1478114-1.0-Don-t-block-content-trackers-by-defa.patch

Comment 2

[Chris Peterson [:cpeterson]]

This sounds like a fix we should uplift to GV 62 Beta for our Focus+GV experiment.

Comment 3

[Eugen Sawin [:esawin]]

(In reply to Chris Peterson [:cpeterson] from comment #2)
> This sounds like a fix we should uplift to GV 62 Beta for our Focus+GV
> experiment.

This will affect Fennec, it won't affect Focus, since we explicitly set the categories there. It will only affect the default behavior when tracking protection is only enabled through the boolean session setting without configuring it through the runtime setting.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da1c50bff11a
[1.0] Don't block content trackers by default to match desktop's default behavior. r=rbarker

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Eugen Sawin [:esawin] from comment #3)
> This will affect Fennec, it won't affect Focus, since we explicitly set the
> categories there. It will only affect the default behavior when tracking
> protection is only enabled through the boolean session setting without
> configuring it through the runtime setting.

Should we uplift this fix for Fennec 62 Beta? Is this a regression in 62 from bug 1466511?

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/da1c50bff11a

Comment 7

[Eugen Sawin [:esawin]]

Comment on attachment 8994636 [details] [diff] [review]
0001-Bug-1478114-1.0-Don-t-block-content-trackers-by-defa.patch

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1466511.
[User impact if declined]: With tracking protection enabled, some sites may not fully load or function due to too restrictive blocking.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Verified on local builds.
[Needs manual test from QE? If yes, steps to reproduce]: I don't think it's required, but one STR is trying to log in using an existing account on nytimes.com.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's only excluding the content blocklist for tracking protection to match the default setting on desktop, no code mechanics changes.
[String changes made/needed]: None.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8994636 [details] [diff] [review]
0001-Bug-1478114-1.0-Don-t-block-content-trackers-by-defa.patch

Fix to bring the fennec/geckoview behavior for tracking protection in line with desktop. Let's uplift for beta 13.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/75b79018fff9

Comment 10

[Sorina Florean [:sflorean]]

Verified as fixed on 62.0b13 following the STR from comment 7.
Devices: Nexus 5(Android 6.0.1) and Samsung Galaxy Note8 (Android 8.0.0)

Comment 11

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly build (63.0a1 - 2018/08/16).
Devices: OnePlus 5T(Android 8.1.0) and Xiaomi Mi4i (Android 5.0.2).