Closed Bug 1466614 Opened 6 years ago Closed 6 years ago

Remove support for the -moz-windows-theme media query

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: dao, Assigned: emilio)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=c++])

Attachments

(1 file)

We don't use this anymore, it was mostly only relevant for Windows XP.
Blocks: 1192090
Blocks: xp-eol
Basically just search moz-windows-theme[1] and remove anything seems to be related. Should be an easy bug to work on.

[1] https://searchfox.org/mozilla-central/search?q=moz-windows-theme&path=
Keywords: good-first-bug
Priority: -- → P4
Whiteboard: [good first bug][lang=c++]
Which file/line needs to remove?

Everything from this list?
https://searchfox.org/mozilla-central/search?q=moz-windows-theme&path=

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #1)
> Basically just search moz-windows-theme[1] and remove anything seems to be
> related. Should be an easy bug to work on.
> 
> [1] https://searchfox.org/mozilla-central/search?q=moz-windows-theme&path=
Flags: needinfo?(xidorn+moz)
Everything from that list plus https://searchfox.org/mozilla-central/search?q=_moz_windows_theme&redirect=false and code surrounding them which is related.
Flags: needinfo?(xidorn+moz)
Assignee: nobody → 1991manish.kumar
How to identify which code is relevant? 

(In reply to Xidorn Quan [:xidorn] UTC+10 (less responsive until July 7) from comment #3)
> Everything from that list plus
> https://searchfox.org/mozilla-central/
> search?q=_moz_windows_theme&redirect=false and code surrounding them which
> is related.
Flags: needinfo?(xidorn+moz)
You should try reading the code and identifying that yourself. I don't think it's hard to follow, and it doesn't matter if you don't get everything right at your first attempt.

You can start with building Firefox, and then remove some known unneeded code, and try to get it build again.
Flags: needinfo?(xidorn+moz)
Blocks: 1479240
Taking since I want to fix bug 1479240 and Manish seems inactive for a bit.
Assignee: 1991manish.kumar → emilio
Comment on attachment 8995765 [details]
Bug 1466614: Remove -moz-windows-theme.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

https://phabricator.services.mozilla.com/D2492
Attachment #8995765 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1711e7ff1052
Remove a no longer used function. r=me CLOSED TREE
(In reply to Pulsebot from comment #10)
> Pushed by emilio@crisal.io:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/1711e7ff1052
> Remove a no longer used function. r=me CLOSED TREE

Undid too much when removing the little Reset() unrelated change :(
https://hg.mozilla.org/mozilla-central/rev/b3baccce3fc4
https://hg.mozilla.org/mozilla-central/rev/1711e7ff1052
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: