Closed
Bug 1466614
Opened 6 years ago
Closed 6 years ago
Remove support for the -moz-windows-theme media query
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: dao, Assigned: emilio)
References
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][lang=c++])
Attachments
(1 file)
We don't use this anymore, it was mostly only relevant for Windows XP.
Comment 1•6 years ago
|
||
Basically just search moz-windows-theme[1] and remove anything seems to be related. Should be an easy bug to work on. [1] https://searchfox.org/mozilla-central/search?q=moz-windows-theme&path=
Comment 2•6 years ago
|
||
Which file/line needs to remove? Everything from this list? https://searchfox.org/mozilla-central/search?q=moz-windows-theme&path= (In reply to Xidorn Quan [:xidorn] UTC+10 from comment #1) > Basically just search moz-windows-theme[1] and remove anything seems to be > related. Should be an easy bug to work on. > > [1] https://searchfox.org/mozilla-central/search?q=moz-windows-theme&path=
Flags: needinfo?(xidorn+moz)
Comment 3•6 years ago
|
||
Everything from that list plus https://searchfox.org/mozilla-central/search?q=_moz_windows_theme&redirect=false and code surrounding them which is related.
Flags: needinfo?(xidorn+moz)
Updated•6 years ago
|
Assignee: nobody → 1991manish.kumar
Comment 4•6 years ago
|
||
How to identify which code is relevant? (In reply to Xidorn Quan [:xidorn] UTC+10 (less responsive until July 7) from comment #3) > Everything from that list plus > https://searchfox.org/mozilla-central/ > search?q=_moz_windows_theme&redirect=false and code surrounding them which > is related.
Flags: needinfo?(xidorn+moz)
Comment 5•6 years ago
|
||
You should try reading the code and identifying that yourself. I don't think it's hard to follow, and it doesn't matter if you don't get everything right at your first attempt. You can start with building Firefox, and then remove some known unneeded code, and try to get it build again.
Flags: needinfo?(xidorn+moz)
Assignee | ||
Comment 6•6 years ago
|
||
Taking since I want to fix bug 1479240 and Manish seems inactive for a bit.
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee: 1991manish.kumar → emilio
Comment 8•6 years ago
|
||
Comment on attachment 8995765 [details] Bug 1466614: Remove -moz-windows-theme. Xidorn Quan [:xidorn] UTC+10 has approved the revision. https://phabricator.services.mozilla.com/D2492
Attachment #8995765 -
Flags: review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/b3baccce3fc4 Remove -moz-windows-theme. r=xidorn
Comment 10•6 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/1711e7ff1052 Remove a no longer used function. r=me CLOSED TREE
Assignee | ||
Comment 11•6 years ago
|
||
(In reply to Pulsebot from comment #10) > Pushed by emilio@crisal.io: > https://hg.mozilla.org/integration/mozilla-inbound/rev/1711e7ff1052 > Remove a no longer used function. r=me CLOSED TREE Undid too much when removing the little Reset() unrelated change :(
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b3baccce3fc4 https://hg.mozilla.org/mozilla-central/rev/1711e7ff1052
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•