Closed Bug 1466658 Opened 3 years ago Closed 3 years ago
Limit preferences in prefs
.rs to those which need a restart of Firefox
59 bytes, text/x-review-board-request
With Firefox 44 the pref "browser.tabs.animate" got removed, and different other animation prefs were moved into "toolkit.cosmeticAnimations.enabled": https://dxr.mozilla.org/mozilla-central/rev/0ee6b755ab2ee6d2ab79b17cc97bd4e83424cbfc/browser/components/nsBrowserGlue.js#1969-1981 Those include: Services.prefs.clearUserPref("browser.tabs.animate"); Services.prefs.clearUserPref("browser.fullscreen.animate"); Services.prefs.clearUserPref("alerts.disableSlidingEffect"); I think especially getting the fullscreen animation disabled would help a lot. Maybe that's the place where Selenium users have issues. Note that Marionette already uses the new pref for a while.
Well UI version doesn't actually map to Firefox version. So the actual change landed in Firefox 55 via bug 1352069. Given that we only support Firefox 55 and greater we can make that change.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P2
Actually this preference is already set as recommended pref in marionette.js. I doubt that it requires a restart of Firefox, so we can actually get it removed from prefs.rs. I will have a look into it.
I will change the summary of the bug so that it covers all preferences which are inappropriately set at both locations. We only have to set preferences in prefs.rs, when those aren't live-updated while Firefox is running.
Summary: Replace preference "browser.tabs.animate" with "toolkit.cosmeticAnimations.enabled" → Limit preferences in prefs.rs to those which need a restart of Firefox
As best I would like to get this also uplifted to Firefox 61, so that we can remove remaining prefs in prefs.rs earlier.
Attachment #8983349 - Flags: review?(ato)
Comment on attachment 8983349 [details] Bug 1466658 - [geckodriver] Overhaul of user preferences in prefs.rs. https://reviewboard.mozilla.org/r/249240/#review255432 ::: commit-message-0ee6b:3 (Diff revision 1) > +Lots of preferences aren't used anymore, or are safe to be set in > +marionette.js to make them version specific to Firefox. “or are safe to set at startup”? ::: testing/geckodriver/CHANGES.md:11 (Diff revision 1) > > Unreleased > ---------- > > Note that with geckodriver 'next' the following versions are recommended: > -- Firefox 56.0 (and greater) > +- Firefox 57.0 (and greater) You should probably also mention in the commit message that this patch bumps the recommended version of Firefox to 57. ::: testing/geckodriver/CHANGES.md:11 (Diff revision 1) > > Unreleased > ---------- > > Note that with geckodriver 'next' the following versions are recommended: > -- Firefox 56.0 (and greater) > +- Firefox 57.0 (and greater) Also change the version number in testing/geckodriver/README.md.
Attachment #8983349 - Flags: review?(ato) → review+
Comment on attachment 8983349 [details] Bug 1466658 - [geckodriver] Overhaul of user preferences in prefs.rs. https://reviewboard.mozilla.org/r/249240/#review255432 > You should probably also mention in the commit message that this > patch bumps the recommended version of Firefox to 57. I also added an entry to Changes.md so we don't forget about it. > Also change the version number in testing/geckodriver/README.md. So many places.... done.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f8c98ae75bbf [geckodriver] Overhaul of user preferences in prefs.rs. r=ato
Please land this test-only patch on beta.
You need to log in before you can comment on or make changes to this bug.