Closed Bug 1466676 Opened 7 years ago Closed 7 years ago

Convert lodash .find() to native ES6

Categories

(Tree Management :: Treeherder: Frontend, defect, P3)

Product:
Tree Management
Component:
Treeherder: Frontend
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jonarea, Assigned: jonarea)

References

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3623
47 bytes, text/x-github-pull-request
camd
: review+
Details | Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36 Steps to reproduce: Converting all _.find() functions to native .find() as outlined in meta Bug 1466494
Assignee: nobody → jonarea
Blocks: 1466494
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
Attachment #8983905 - Flags: review?(cdawson)
Requested changes in PR.
Comment on attachment 8983905 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3623 Requested an update. Clearing review for now.
Flags: needinfo?(cdawson)
Attachment #8983905 - Flags: review?(cdawson)
Clearing my own need-info while I wait for fixes from the contributor.
Flags: needinfo?(cdawson)
Flags: needinfo?(cdawson)
Comment on attachment 8983905 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3623 Great work! Thanks!
Flags: needinfo?(cdawson)
Attachment #8983905 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 1472617
Depends on: 1472096
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: