Closed
Bug 1472096
Opened 7 years ago
Closed 7 years ago
Cannot reset alert
Categories
(Tree Management :: Perfherder, defect, P1)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: igoldan, Assigned: igoldan)
References
Details
(Keywords: regression)
Attachments
(1 file)
Steps to reproduce:
1. Go to alert summary https://treeherder.mozilla.org/perf.html#/alerts?id=14050
2. Reset "Base Content Explicit windows7-32 opt stylo" alert
Expected result: Alert goes back to "untriaged" state.
Actual result : Getting a console error 'TypeError: "ae is not iterable"'.
|
||
Comment 1•7 years ago
|
||
The unminifed exception is: 'TypeError: "b is not iterable"' in summariesToUpdate:
https://github.com/mozilla/treeherder/blame/b60771607721ca3190865d30a0f373b3157326c2/ui/js/controllers/perf/alerts.js#L391-L395
The two most recent changes are:
https://github.com/mozilla/treeherder/commit/e40793192110f53bb5ecb94cb81c81c0a0a986b2#diff-d5c3abf248b638a13014d6259abba31aL392
https://github.com/mozilla/treeherder/commit/9b3ba7149b865bc58be7eed284ae98be77a25d8f#diff-d5c3abf248b638a13014d6259abba31aL392
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → igoldan
|
||
Comment 2•7 years ago
|
||
|
|
||
Updated•7 years ago
|
Blocks: 1466676
Keywords: regression
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8989153 -
Flags: review?(wlachance)
|
||
Updated•7 years ago
|
Attachment #8989153 -
Flags: review?(wlachance) → review+
|
||
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/b5ea30578a5587ce925899418e3e72c67290cce3
Bug 1472096 - Fix TypeError in AlertsCtrl resetAlerts() (#3750)
|
|
||
Comment 4•7 years ago
|
||
Prod deploy in progress.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•