1466864 - [Xfce 4.12][CSD] Leaving fullscreen on Firefox 60.0.1 on Linux with title bar disabled leaves window unmaximized

Status: RESOLVED INVALID

(Core :: Widget: Gtk, defect)

Description

[juef17]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180517114003

Steps to reproduce:

- Launch Firefox 60.0.1 on Linux (I'm using Linux Lite 4.0 which uses Xfce 4.12)
- Maximize the window
- Disable the title bar by right-clicking the tab bar and unchecking 'Title Bar'
- Go in fullscreen with F11 (or button on HTML5 player, e.g. YouTube), and leave it by the same mean


Actual results:

Window is now unmaximized.


Expected results:

Window should have been maximized, as it was before going fullscreen.

Comment 1

[juef17]

Others seem to have this problem as well:

https://www.linuxliteos.com/forums/other/firefox-window-not-maximized-after-leaving-fullscreen-html5-video/
https://www.reddit.com/r/firefox/comments/8oha2q/firefox_window_not_maximized_after_leaving/

Windows seems to be unaffected.

Comment 2

[[:philipp]]

hi, is this a new problem in firefox 60? if yes, could you try to run the mozregression tool from https://mozilla.github.io/mozregression/quickstart.html in order to narrow down the regression range and perhaps the bug which has introduced this problem?

Comment 3

[juef17]

What a great tool! Here's what it had to say in the "Bisection informations" section:

app_name: firefox
build_date: 2017-12-06 10:47:35.315000
build_file: /home/francois/.mozilla/mozregression/persist/72a55f390248--autoland--target.tar.bz2
build_type: inbound
build_url: https://queue.taskcluster.net/v1/task/diYmn-6DRi-6157jYLVMTg/runs/0/artifacts/public%2Fbuild%2Ftarget.tar.bz2
changeset: 72a55f3902489b59edb3a650cc27d9693f413529
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ce401a7898ee492f5854b275a4a5368679f85702&tochange=72a55f3902489b59edb3a650cc27d9693f413529
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: diYmn-6DRi-6157jYLVMTg


And here's the relevant output from the log view:

2018-06-07T21:23:54: INFO : Narrowed inbound regression window from [ce401a78, ed817bc6] (4 builds) to [a27e933a, ed817bc6] (2 builds) (~1 steps left)
2018-06-07T21:23:54: DEBUG : Starting merge handling...
2018-06-07T21:23:54: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=ed817bc6cc3bc2a11e9607afb3c5b52702ceb12a&full=1
2018-06-07T21:23:55: DEBUG : Found commit message:
Bug 1421974 - use gtk_window_set_titlebar() to hide titlebar on WM where GDK_DECOR_BORDER does not work, r=jhorak

This patch is based on Karl Tomlinson's (:karlt) demo from Bug 1419456. We use gtk_window_set_titlebar()
to set invisible widget. The widget takes place of GtkHeaderBar which leads Gtk+ to render CSD shadows
and handle window resizing, it does not render any titlebar.

gtk_window_set_titlebar() works on unrealized windows only and mShell is already realized at time
of nsWindow::SetDrawsInTitlebar() call so we need to update recent GtkWidget setup.

In that case we create GdkWindow for mContainer (instead of mShell), create a temporary GtkWindow,
reparent mContainer (which owns mGdkWindow) to it, unrealize mShell and set up the titlebar
for mShell toplevel window.

As a workaround for Gtk+ Bug 791081 we also allocate some valid size for mShell before it's newly realized
with the updated titlebar.

MozReview-Commit-ID: A3KwRoOzoko

Comment 4

[[:philipp]]

great, thank you Juef17 for coming up with a regression range! 
the issue is also coming up in the support forum: https://support.mozilla.org/en-US/questions/firefox?owner=all&tagged=bug1466864&show=all

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Yes, this is a bug in client side decorations handling and disabled titlebar. Actually it's not a regression because it never worked - the disabled titlebar is a new feature at Firefox 60 and we have a bug here at CSD handling.

Comment 6

[juef17]

I'm not sure I understand what you're saying: when I was using mozregression, there were definitely some releases (nightly I guess) that could disable the titlebar and yet exit fullscreen while leaving the window maximized. But I'm probably missing something here. Thank you for your help!

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to juef17 from comment #6)
> I'm not sure I understand what you're saying: when I was using
> mozregression, there were definitely some releases (nightly I guess) that
> could disable the titlebar and yet exit fullscreen while leaving the window
> maximized. But I'm probably missing something here. Thank you for your help!

I see. That's probably that build does not use CSD titlebar mode. Can you try to run firefox as:

$MOZ_GTK_TITLEBAR_DECORATION=system firefox

and also which desktop do you run?

Comment 8

[juef17]

Forgive my ignorance, but is that dollar symbol supposed to be there?

 francois  ~  $MOZ_GTK_TITLEBAR_DECORATION=system firefox
=system: command not found

Removing the $ does start Firefox, but unfortunately, I see no difference in its behavior.

I am running Linux Lite 4.0 with Xfce 4.12.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

(In reply to juef17 from comment #8)
> Forgive my ignorance, but is that dollar symbol supposed to be there?

Sorry, that's bash shell default prompt. Never mind that.

>  francois  ~  $MOZ_GTK_TITLEBAR_DECORATION=system firefox
> =system: command not found
> 
> Removing the $ does start Firefox, but unfortunately, I see no difference in
> its behavior.

That's fine, Thanks.

> I am running Linux Lite 4.0 with Xfce 4.12.

Comment 11

[laichiaheng]

It happens to me on my Manjaro XFCE edition Linux PC, too.
Firefox version: 60.0.2

Comment 12

[eimantas]

Still happens in 61.0
Arch Linux XFCE

Comment 13

[Romain P]

Nightly 63.0a1 running on Xubuntu 16.04 (Xfce 4.12) is also affected.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

(In reply to juef17 from comment #6)
> I'm not sure I understand what you're saying: when I was using
> mozregression, there were definitely some releases (nightly I guess) that
> could disable the titlebar and yet exit fullscreen while leaving the window
> maximized. But I'm probably missing something here. Thank you for your help!

I can reproduce it now, Thanks. The regression is correct but the code used before the Bug 1421974 didn't allow to resize main window as it sets borderless main window.

What we need is to fix or adjust CSD mode for XFCE as it does not support GDK_DECOR_BORDER mode. Also I can reproduce that on XFCE only, other WM works fine AFAIK so I tend to say it's a bug in XFCE window manager.

Comment 15

[Martin Stránský [:stransky] (ni? me)]

The problem here is that XFCE sends "window-state-event" with aEvent->new_window_state == GDK_WINDOW_STATE_FOCUSED only after gtk_window_unfullscreen() and nothing else.

Other WM also sends the original window state which the window had before gtk_window_fullscreen() call.

Comment 16

[Martin Stránský [:stransky] (ni? me)]

Attachment: testcase

There's a simple testcase which shows that bug on XFCE. Works fine on other WM.

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Filed as https://bugzilla.xfce.org/show_bug.cgi?id=14511

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Fixed on xfce side, closing.