Closed Bug 1467089 Opened 7 years ago Closed 7 years ago

Missing nick colors on Bubble and Dark message themes

Categories

(Thunderbird :: Instant Messaging, defect)

Product:
Thunderbird
Component:
Instant Messaging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird61 wontfix, thunderbird62 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 62.0
Tracking Flags:
Tracking Status
thunderbird61 --- wontfix
thunderbird62 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Patch v2
3.48 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review
When preparing a patch for bug 1433871, I forgot the nickColor attribute.
Attached patch Patch (obsolete) — — Splinter Review
Comment on attachment 8983720 [details] [diff] [review] Patch Thanks.
Attachment #8983720 - Flags: review+
Bah, I missed another attribute: Removed unsafe attribute. Element: span. Attribute: left.
Attached patch Patch v2 — — Splinter Review
Attachment #8983720 - Attachment is obsolete: true
Comment on attachment 8983761 [details] [diff] [review] Patch v2 Thanks again.
Attachment #8983761 - Flags: review+
Comment on attachment 8983761 [details] [diff] [review] Patch v2 Only needed for TB 61 beta if that ever gets built. Not needed in TB 60 beta/ESR.
Attachment #8983761 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/15001f098daa Bug 1433871 follow-up: add a data- prefix on the nickColor and left attributes. r=jorgk
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 62.0
Attachment #8983761 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: