1467337 - Don't allow --enable-stdcxx-compat when the linker is gold

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

See bug 1464084 comment 26.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1467337 - Don't allow --enable-stdcxx-compat when the linker is gold.

Review commit: https://reviewboard.mozilla.org/r/249884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249884/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8984012 [details]
Bug 1467337 - Don't allow --enable-stdcxx-compat when the linker is gold.

https://reviewboard.mozilla.org/r/249884/#review256072

Technically the patch looks fine.  I can't confirm that this is sensible policy, but I trust your analysis.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71ed3b0b1013
Don't allow --enable-stdcxx-compat when the linker is gold. r=nalexander

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 71ed3b0b1013 (bug 1467337) for build bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=182892324&repo=autoland&lineNumber=1030

INFO -  client.mk:123: recipe for target 'configure' failed
[task 2018-06-12T05:17:29.305Z] 05:17:29     INFO -  make: *** [configure] Error 1
[task 2018-06-12T05:17:29.356Z] 05:17:29    ERROR - Return code: 2
[task 2018-06-12T05:17:29.356Z] 05:17:29  WARNING - setting return code to 2
[task 2018-06-12T05:17:29.356Z] 05:17:29    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2018-06-12T05:17:29.356Z] 05:17:29    FATAL - Running post_fatal callback...
[task 2018-06-12T05:17:29.357Z] 05:17:29    FATAL - Exiting -1
[task 2018-06-12T05:17:29.357Z] 05:17:29     INFO - [mozharness: 2018-06-12 05:17:29.357175Z] Finished build step (failed)
[task 2018-06-12T05:17:29.357Z] 05:17:29     INFO - Running post-run listener: _summarize
[task 2018-06-12T05:17:29.357Z] 05:17:29    ERROR - # TBPL FAILURE #
[task 2018-06-12T05:17:29.357Z] 05:17:29     INFO - [mozharness: 2018-06-12 05:17:29.357495Z] FxDesktopBuild summary:
[task 2018-06-12T05:17:29.357Z] 05:17:29    ERROR - # TBPL FAILURE #
[task 2018-06-12T05:17:29.357Z] 05:17:29     INFO - Running post-run listener: copy_logs_to_upload_dir
[task 2018-06-12T05:17:29.357Z] 05:17:29     INFO - Copying logs to upload dir...

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=71ed3b0b10135d19861cf4c42e0fc2fbe36557ab&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Backout:
https://hg.mozilla.org/integration/autoland/rev/1eada07ecc31d2c5a86c03e105adea23c7b79a4f

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1467337 - Don't allow --enable-stdcxx-compat when the linker is gold.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad51d125a877
Don't allow --enable-stdcxx-compat when the linker is gold. r=nalexander

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ad51d125a877