Closed
Bug 1467504
Opened 7 years ago
Closed 7 years ago
Convert lodash .uniq() to native ES6 JS
Categories
(Tree Management :: Treeherder: Frontend, defect, P3)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evct, Assigned: evct)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.170 Safari/537.36 OPR/53.0.2907.68
Steps to reproduce:
Converting all _.uniq() (lodash) functions to native [...new Set()] (ES6 JS)
|
||
Updated•7 years ago
|
Assignee: nobody → oss
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
|
||
Comment 1•7 years ago
|
||
|
|
||
Updated•7 years ago
|
Attachment #8984210 -
Flags: review?(cdawson)
|
||
Comment 2•7 years ago
|
||
Sorry for the delay in reviewing these. There were quite a few. :) I'll try to get these done on the flight down to SF on Monday.
|
||
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/d184bd224cb3026635b613e04ef668f3a18b13d5
Bug 1467504 - convert _uniq() usages to ES6 (#3634)
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8984210 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3634
Thanks for the PR! Nice work!
Attachment #8984210 -
Flags: review?(cdawson) → review+
|
|
||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•