1469767 - Untriaged Talos alerts fail to display

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P1)

Description

[Ionuț Goldan [:igoldan]]

Production Perfherder dumps an error in the console:

TypeError: le is not iterable Stack trace: addAlertSummaries/</</ae.downstreamSummaryIds<@https://treeherder.mozilla.org/perf.476e6440429d6f7813f6.bundle.js:44:6231 addAlertSummaries/</<@https://treeherder.mozilla.org/perf.476e6440429d6f7813f6.bundle.js:44:6108 addAlertSummaries/<@https://treeherder.mozilla.org/perf.476e6440429d6f7813f6.bundle.js:44:5723 processQueue@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:355504 scheduleProcessQueue/<@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:356170 $digest@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:363866 $apply@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:366141 scheduleApplyAsync/Li<@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:360964 completeOutstandingRequest@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:293392 Browser/Ui.defer/ls<@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:295289

with a TypeError that's saying:

columnNumber: 6231
​
fileName: "https://treeherder.mozilla.org/perf.476e6440429d6f7813f6.bundle.js"
​
lineNumber: 44
​
message: "le is not iterable"
​
stack: "addAlertSummaries/</</ae.downstreamSummaryIds<@https://treeherder.mozilla.org/perf.476e6440429d6f7813f6.bundle.js:44:6231\naddAlertSummaries/</<@https://treeherder.mozilla.org/perf.476e6440429d6f7813f6.bundle.js:44:6108\naddAlertSummaries/<@https://treeherder.mozilla.org/perf.476e6440429d6f7813f6.bundle.js:44:5723\nprocessQueue@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:355504\nscheduleProcessQueue/<@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:356170\n$digest@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:363866\n$apply@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:366141\nscheduleApplyAsync/Li<@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:360964\ncompleteOutstandingRequest@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:293392\nBrowser/Ui.defer/ls<@https://treeherder.mozilla.org/vendor.5f0f241e916dd98c1912.bundle.js:45:295289\n"

I didn't notice this problem yesterday.

Comment 1

[Ionuț Goldan [:igoldan]]

To reproduce this, simply go to Perfherder's default page:

https://treeherder.mozilla.org/perf.html#/alerts?status=0&framework=1&hideDwnToInv=1&page=1

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3683

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8986389 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3683

Thank you for tracking this down and opening a PR :-)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4861869f12c4bd7f390a7026906ff3a17fd12a74
Bug 1469767 - Fix TypeError in addAlertSummaries (#3683)

Map must return same output type.

Comment 5

[Ed Morley [:emorley]]

Deployed to production 20 minutes ago.