Closed
Bug 1467566
Opened 6 years ago
Closed 6 years ago
Theme.get() should return values for built-in themes
Categories
(WebExtensions :: Themes, enhancement)
WebExtensions
Themes
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1435216
People
(Reporter: ddurst, Unassigned)
Details
With the move away from LWT, it makes sense to consider the built-in themes (certainly 'dark' and 'light') as peers of user themes, at least from the perspective of Theme.get(). In our work on browser_style (bug 1458678), one of the approaches is to recommend that developers use the Theme API to get values to apply to sidebars, panels, etc if they want to unify those with the current theme. This would make that possible for users of those built-in themes. And if we allowed it for 'default' as well, then it would work across the board -- though technically I guess the default values would be what those users would get. Not sure if there's a reason to not let all the built-ins return to Theme.get().
Reporter | ||
Updated•6 years ago
|
Priority: P3 → --
Updated•6 years ago
|
Product: Toolkit → WebExtensions
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•